Code to turn on VINCIA plugin version 2

[mkirsano]

No description provided.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mkirsano]

To be tested against cmsdist #3480

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1120

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1120/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1120/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1122

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1122/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1122/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[efeyazgan]

please test with cms-sw/cmsdist#3480

[smuzaffar]

@mkirsano , code-checks should be passed before bot can start the normal tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1152

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1152/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20733/1152/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20733/23656/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2766087
• DQMHistoTests: Total failures: 105
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2765811
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[perrozzi]

so @mkirsano you say that this version of the plugin is not compatible with pythia8 230 right?

[mkirsano]

I will look a bit more into this. VINCIA itself compiles with pythia8 230.

[smuzaffar]

please test with cms-sw/cmsdist#3480

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3480
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23772/console

[cmsbuild]

+1
Tested at: 2922d43
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20733/23772/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
42f293a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20733/23772/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20733/23772/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20733/23772/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2767139
• DQMHistoTests: Total failures: 113
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2766855
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge