Fix xerces xmlparser issue in aarch64 unique_ptr related sigsegv

[mrodozov]

This PR fixes the latest Xerces related relval fails in aarch64 listed here
https://cms-sw.github.io/relvalLogDetail.html#slc7_aarch64_gcc700;CMSSW_9_4_X_2017-10-03-2300
with this description
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_aarch64_gcc700/CMSSW_9_4_X_2017-10-03-2300/pyRelValMatrixLogs/run/5.2_SingleMuPt10+SingleMuPt10FS+HARVESTFS/step1_SingleMuPt10+SingleMuPt10FS+HARVESTFS.log
which were due to this object

cmssw/Geometry/VeryForwardGeometryBuilder/src/RPAlignmentCorrectionsDataSequence.cc

Line 81 in efff9c2

auto parser = std::make_unique<XercesDOMParser>();

not properly deleted (or pointer still pointing somewhere it was not supposed to) when going out of scope
even though the recipe prescribed by apache
https://xerces.apache.org/xerces-c/program-3.html
was properly repeated.
Similar implementations of the same thing exists also in other places in CMSSW :
https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=XMLPlatformUtils%3A%3ATerminate%28%29&type=

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20742/1143

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23440/console Started: 2017/10/04 17:51

[cmsbuild]

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

Geometry/VeryForwardGeometryBuilder

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 98a7b0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20742/23440/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
024141f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20742/23440/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20742/23440/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20742/23440/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761357
• DQMHistoTests: Total failures: 251
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760919
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[smuzaffar]

+geometry

[smuzaffar]

@davidlange6 , can we get this in for 23h00 IB. This properly deletes the XercesDOMParser before Xerces Terminate

[davidlt]

Btw, this is also happening on x86_64 (I got 15 workflows fail in short matrix).

[davidlange6]

seems we have a problem with each change affecting xerces..

[davidlange6]

merge