clang-tidy checks for Alignment subsystem

[davidlange6]

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this tomorrow to avoid conflicts to the extent possible]

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20753/1166

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/APEEstimation
Alignment/CocoaApplication
Alignment/CocoaDDLObjects
Alignment/CocoaDaq
Alignment/CocoaFit
Alignment/CocoaModel
Alignment/CocoaToDDL
Alignment/CocoaUtilities
Alignment/CommonAlignment
Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentParametrization
Alignment/CommonAlignmentProducer
Alignment/Geners
Alignment/HIPAlignmentAlgorithm
Alignment/LaserAlignment
Alignment/LaserAlignmentSimulation
Alignment/LaserDQM
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/MuonAlignmentAlgorithms
Alignment/OfflineValidation
Alignment/ReferenceTrajectories
Alignment/SurveyAnalysis
Alignment/TrackerAlignment

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @abbiendi, @jhgoh, @tocheng, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23469/console Started: 2017/10/05 16:47

[cmsbuild]

+1
Tested at: 576a70d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20753/23469/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f6b2f91
5d51435
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20753/23469/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20753/23469/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20753/23469/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761427
• DQMHistoTests: Total failures: 251
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760989
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[ghellwig]

+1
thanks for removing this item from my personal to-do list ;)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge On 5 Oct 2017, at 22:20, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote: This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6<https://github.com/davidlange6>, @slava77<https://github.com/slava77>, @smuzaffar<https://github.com/smuzaffar> (and backports should be raised in the release meeting by the corresponding L2) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#20753 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw1lFyJGox-lsdzDJaHa1fHTxgOdNks5spTnUgaJpZM4PvHkE>.