clang-tidy checks for CalibTracker subsystem

[davidlange6]

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this tomorrow to avoid conflicts to the extent possible]

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20757/1172

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CalibTracker/SiPixelConnectivity
CalibTracker/SiPixelESProducers
CalibTracker/SiPixelErrorEstimation
CalibTracker/SiPixelGainCalibration
CalibTracker/SiPixelIsAliveCalibration
CalibTracker/SiPixelLorentzAngle
CalibTracker/SiPixelSCurveCalibration
CalibTracker/SiPixelTools
CalibTracker/SiStripAPVAnalysis
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripDCS
CalibTracker/SiStripESProducers
CalibTracker/SiStripHitEfficiency
CalibTracker/SiStripLorentzAngle
CalibTracker/SiStripQuality

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @gbenelli, @tocheng, @argiro, @mverzett, @dkotlins, @OlivierBondu, @mmusich, @jlagram this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23476/console Started: 2017/10/05 18:43

[cmsbuild]

+1
Tested at: bf724d9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20757/23476/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f6b2f91
5d51435
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20757/23476/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20757/23476/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20757/23476/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761427
• DQMHistoTests: Total failures: 245
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760995
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[ghellwig]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1