Fix compilation warnings in CalibCalorimetry pkg

[mrodozov]

This PR fixes the warnings from CalibCalorimetry pkg after clang-tidy checks modifications done here #20755

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20769/1193

[cmsbuild]

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos
CalibCalorimetry/EcalLaserAnalyzer

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23495/console Started: 2017/10/06 14:36

[ghellwig]

+1
provided jenkins agrees
@smuzaffar is it possible to include this in the code checks?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@ghellwig , we are thinking the same.

[cmsbuild]

+1
Tested at: 8569c45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20769/23495/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2c8fb8d
c4961f5
c511cf0
4b54a5f
a67f887
de38a5e
e693089
d89d440
4390117
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20769/23495/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20769/23495/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20769/23495/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 62 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761427
• DQMHistoTests: Total failures: 426
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760814
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[davidlange6]

+1