clang-tidy checks for CalibCalorimetry subsystem

[davidlange6]

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this tomorrow to avoid conflicts to the extent possible]

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20755/1168

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CalibCalorimetry/CaloMiscalibTools
CalibCalorimetry/CaloTPG
CalibCalorimetry/CastorCalib
CalibCalorimetry/EcalCorrectionModules
CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos
CalibCalorimetry/EcalCorrelatedNoiseAnalysisModules
CalibCalorimetry/EcalLaserAnalyzer
CalibCalorimetry/EcalLaserCorrection
CalibCalorimetry/EcalLaserSorting
CalibCalorimetry/EcalPedestalOffsets
CalibCalorimetry/EcalSRTools
CalibCalorimetry/EcalTPGTools
CalibCalorimetry/EcalTrivialCondModules
CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGIO

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mulhearn, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23467/console Started: 2017/10/05 16:43

[cmsbuild]

+1
Tested at: 8876bb8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20755/23467/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f6b2f91
5d51435
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20755/23467/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20755/23467/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20755/23467/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761427
• DQMHistoTests: Total failures: 258
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760982
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[ghellwig]

+1

[davidlange6]

+1

[davidlange6]

merge