Remove unnecessary find()s, commented couts; tidy

[wmtford]

Remove three instances of unnecessary use of find() to access a detSet inside an iteration over detSets. Implement auto and range-based for() loops. Implement clang-tidy modernizations. Remove commented couts. No change in results.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20835/1280

[cmsbuild]

A new Pull Request was created by @wmtford (Bill Ford) for master.

It involves the following packages:

Validation/TrackerRecHits

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@threus, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23641/console Started: 2017/10/10 15:14

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 044d404
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20835/23641/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
02d60c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20835/23641/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20835/23641/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20835/23641/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2764467
• DQMHistoTests: Total failures: 110
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2764186
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[davidlange6]

+1