Clang-tidy checks for FastSimulation

[davidlange6]

PR to apply clang-tidy checks to all files except those that are a part of open pull requests (as of an hour ago) and files in test directories [assuming tests are ok we'll merge this quickly to avoid conflicts to the extent possible]

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20853/1297

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FastSimulation/CTPPSFastGeometry
FastSimulation/CTPPSFastTrackingProducer
FastSimulation/CTPPSRecHitProducer
FastSimulation/CTPPSSimHitProducer
FastSimulation/CaloHitMakers
FastSimulation/CalorimeterProperties
FastSimulation/Calorimetry
FastSimulation/Event
FastSimulation/EventProducer
FastSimulation/ForwardDetectors
FastSimulation/MaterialEffects
FastSimulation/MuonSimHitProducer
FastSimulation/Muons
FastSimulation/Particle
FastSimulation/ParticleDecay
FastSimulation/ParticlePropagator
FastSimulation/ShowerDevelopment
FastSimulation/TrackerSetup
FastSimulation/Tracking
FastSimulation/TrackingRecHitProducer
FastSimulation/TrajectoryManager
FastSimulation/Utilities
FastSimulation/Validation

The following packages do not have a category, yet:

FastSimulation/CTPPSFastGeometry
FastSimulation/CTPPSFastTrackingProducer
FastSimulation/CTPPSRecHitProducer
FastSimulation/CTPPSSimHitProducer
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23597/console Started: 2017/10/09 17:28

[cmsbuild]

+1
Tested at: 566fa4c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20853/23597/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7080a69
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20853/23597/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20853/23597/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20853/23597/summary.html

There are some workflows for which there are errors in the baseline:
11624.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2632155
• DQMHistoTests: Total failures: 86
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2631900
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[davidlange6]

merge