[94x] L1T OMTF introduce packer, unpacker, config DQM #20859

rekovic · 2017-10-09T15:38:09Z

[94x] Introduce

OMTF packer, needed for 94x MC.
OMTF unpacker
switch OMTF emulator to use unpacked OMTF in DQM (simple changes in configuration files)

Total 43 files, but 8 files are configurations.

cmsbuild · 2017-10-09T15:38:49Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-10-09T15:43:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20859/1313

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20859/1313/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20859/1313/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2017-10-09T15:54:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-10-09T15:57:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20859/1315

cmsbuild · 2017-10-09T15:58:10Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

DQM/L1TMonitor
DQM/L1TMonitorClient
EventFilter/L1TRawToDigi
L1Trigger/L1TMuonOverlap

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

rekovic · 2017-10-09T16:07:28Z

please test

cmsbuild · 2017-10-09T16:07:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23610/console Started: 2017/10/09 19:14

cmsbuild · 2017-10-09T19:09:42Z

-1

Tested at: 77c41c1

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7080a69
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23610/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23610/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23610/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

135.4 step2

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step2_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

5.1 step2

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step2_TTbar+TTbarFS+HARVESTFS.log

7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17/step3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7080a69
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23610/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23610/git-merge-result

cmsbuild · 2017-10-09T19:09:44Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-10-21T10:06:09Z

Pull request #20859 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please check and sign again.

cmsbuild · 2017-10-21T10:19:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-10-21T10:23:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20859/1587

rekovic · 2017-10-21T10:23:30Z

please test

cmsbuild · 2017-10-21T10:23:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23913/console Started: 2017/10/21 12:24

cmsbuild · 2017-10-21T10:23:43Z

Pull request #20859 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please check and sign again.

cmsbuild · 2017-10-21T12:43:00Z

+1
Tested at: 38f7b9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23913/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e887141
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23913/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23913/git-merge-result

cmsbuild · 2017-10-21T12:43:03Z

Comparison job queued.

cmsbuild · 2017-10-21T14:14:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20859/23913/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2795796
DQMHistoTests: Total failures: 111
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2795513
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

rekovic · 2017-10-21T16:29:09Z

+1

davidlange6 · 2017-10-21T17:08:39Z

merge

kpedro88 · 2017-11-24T04:39:11Z

EventFilter/L1TRawToDigi/src/OmtfLinkMappingRpc.cc

+            LinkBoardElectronicIndex rpcEle = { it1->id(), it2.dccInputChannelNum(), it3.triggerBoardInputNumber(), it4->linkBoardNumInLink()};
+            for ( const auto & omtfEle : omtfEles ) omtf2rpc[omtfEle]= rpcEle;
+          }
+          catch(...) { ; } // std::cout << "exception! "<<it4->linkBoardName()<< std::endl; }


Why was this egregious, unnecessary use of try/catch allowed to persist? It is effectively impossible to debug any real exception now.

cmsbuild added this to the CMSSW_9_4_X milestone Oct 9, 2017

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Oct 9, 2017

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 9, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 9, 2017

davidlange6 mentioned this pull request Oct 13, 2017

"Showstoppers" for CMSSW_9_4_0_pre3 (and thus CMSSW_9_4_0) closing #20867

Closed

Address comments: one more const &.

38f7b9a

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 21, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 21, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 21, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 21, 2017

cmsbuild added l1-approved and removed l1-pending labels Oct 21, 2017

cmsbuild added orp-approved and removed orp-pending labels Oct 21, 2017

cmsbuild merged commit 2eb7907 into cms-sw:master Oct 21, 2017

slava77 mentioned this pull request Oct 23, 2017

Add possibility to cut on timing to IVF #20640

Merged

kpedro88 reviewed Nov 24, 2017

View reviewed changes

kpedro88 mentioned this pull request Nov 27, 2017

Remove try/catch in OmtfLinkMappingRpc #21465

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[94x] L1T OMTF introduce packer, unpacker, config DQM #20859

[94x] L1T OMTF introduce packer, unpacker, config DQM #20859

rekovic commented Oct 9, 2017 •

edited

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

rekovic commented Oct 9, 2017

cmsbuild commented Oct 9, 2017 •

edited

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

rekovic commented Oct 21, 2017

cmsbuild commented Oct 21, 2017 •

edited

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

rekovic commented Oct 21, 2017

davidlange6 commented Oct 21, 2017

kpedro88 Nov 24, 2017

[94x] L1T OMTF introduce packer, unpacker, config DQM #20859

[94x] L1T OMTF introduce packer, unpacker, config DQM #20859

Conversation

rekovic commented Oct 9, 2017 • edited

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

rekovic commented Oct 9, 2017

cmsbuild commented Oct 9, 2017 • edited

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 9, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

rekovic commented Oct 21, 2017

cmsbuild commented Oct 21, 2017 • edited

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

cmsbuild commented Oct 21, 2017

rekovic commented Oct 21, 2017

davidlange6 commented Oct 21, 2017

kpedro88 Nov 24, 2017

Choose a reason for hiding this comment

rekovic commented Oct 9, 2017 •

edited

cmsbuild commented Oct 9, 2017 •

edited

cmsbuild commented Oct 21, 2017 •

edited