New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved fastSim reconstruction to use era #20884
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,3 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| # import the full tracking equivalent of this file | ||
| import RecoTracker.IterativeTracking.DetachedTripletStep_cff as _standard | ||
| from FastSimulation.Tracking.SeedingMigration import _hitSetProducerToFactoryPSet | ||
|
|
||
| # fast tracking mask producer | ||
| import FastSimulation.Tracking.FastTrackerRecHitMaskProducer_cfi | ||
| detachedTripletStepMasks = FastSimulation.Tracking.FastTrackerRecHitMaskProducer_cfi.maskProducerFromClusterRemover(_standard.detachedTripletStepClusters) | ||
|
|
||
| # tracking regions | ||
| detachedTripletStepTrackingRegions = _standard.detachedTripletStepTrackingRegions.clone() | ||
|
|
||
| # trajectory seeds | ||
| import FastSimulation.Tracking.TrajectorySeedProducer_cfi | ||
| detachedTripletStepSeeds = FastSimulation.Tracking.TrajectorySeedProducer_cfi.trajectorySeedProducer.clone( | ||
| layerList = _standard.detachedTripletStepSeedLayers.layerList.value(), | ||
| trackingRegions = "detachedTripletStepTrackingRegions", | ||
| hitMasks = cms.InputTag("detachedTripletStepMasks") | ||
| ) | ||
| detachedTripletStepSeeds.seedFinderSelector.pixelTripletGeneratorFactory = _hitSetProducerToFactoryPSet(_standard.detachedTripletStepHitTriplets) | ||
|
|
||
| # track candidates | ||
| import FastSimulation.Tracking.TrackCandidateProducer_cfi | ||
| detachedTripletStepTrackCandidates = FastSimulation.Tracking.TrackCandidateProducer_cfi.trackCandidateProducer.clone( | ||
| src = cms.InputTag("detachedTripletStepSeeds"), | ||
| MinNumberOfCrossedLayers = 3, | ||
| hitMasks = cms.InputTag("detachedTripletStepMasks") | ||
| ) | ||
|
|
||
| # tracks | ||
| detachedTripletStepTracks = _standard.detachedTripletStepTracks.clone(TTRHBuilder = 'WithoutRefit') | ||
|
|
||
| detachedTripletStepClassifier1 = _standard.detachedTripletStepClassifier1.clone() | ||
| detachedTripletStepClassifier1.vertices = "firstStepPrimaryVerticesBeforeMixing" | ||
| detachedTripletStepClassifier2 = _standard.detachedTripletStepClassifier2.clone() | ||
| detachedTripletStepClassifier2.vertices = "firstStepPrimaryVerticesBeforeMixing" | ||
|
|
||
| detachedTripletStep = _standard.detachedTripletStep.clone() | ||
|
|
||
| # Final sequence | ||
| DetachedTripletStep = cms.Sequence(detachedTripletStepMasks | ||
| +detachedTripletStepTrackingRegions | ||
| +detachedTripletStepSeeds | ||
| +detachedTripletStepTrackCandidates | ||
| +detachedTripletStepTracks | ||
| +detachedTripletStepClassifier1*detachedTripletStepClassifier2 | ||
| +detachedTripletStep | ||
| ) | ||
| # all work is now done using fastSim era | ||
| from RecoTracker.IterativeTracking.DetachedTripletStep_cff import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,3 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| # import the full tracking equivalent of this file | ||
| import RecoTracker.IterativeTracking.InitialStep_cff as _standard | ||
| from FastSimulation.Tracking.SeedingMigration import _hitSetProducerToFactoryPSet | ||
|
|
||
| # tracking regions | ||
| initialStepTrackingRegions = _standard.initialStepTrackingRegions.clone() | ||
|
|
||
| # trajectory seeds | ||
| import FastSimulation.Tracking.TrajectorySeedProducer_cfi | ||
| initialStepSeeds = FastSimulation.Tracking.TrajectorySeedProducer_cfi.trajectorySeedProducer.clone( | ||
| layerList = _standard.initialStepSeedLayers.layerList.value(), | ||
| trackingRegions = "initialStepTrackingRegions" | ||
| ) | ||
| initialStepSeeds.seedFinderSelector.pixelTripletGeneratorFactory = _hitSetProducerToFactoryPSet(_standard.initialStepHitTriplets) | ||
| initialStepSeeds.seedFinderSelector.pixelTripletGeneratorFactory.SeedComparitorPSet.ComponentName = "none" | ||
|
|
||
| # track candidates | ||
| import FastSimulation.Tracking.TrackCandidateProducer_cfi | ||
| initialStepTrackCandidates = FastSimulation.Tracking.TrackCandidateProducer_cfi.trackCandidateProducer.clone( | ||
| src = cms.InputTag("initialStepSeeds"), | ||
| MinNumberOfCrossedLayers = 3 | ||
| ) | ||
|
|
||
| # tracks | ||
| initialStepTracks = _standard.initialStepTracks.clone(TTRHBuilder = 'WithoutRefit') | ||
|
|
||
| firstStepPrimaryVerticesBeforeMixing = _standard.firstStepPrimaryVerticesUnsorted.clone() | ||
|
|
||
| # final selection | ||
| initialStepClassifier1 = _standard.initialStepClassifier1.clone() | ||
| initialStepClassifier1.vertices = "firstStepPrimaryVerticesBeforeMixing" | ||
| initialStepClassifier2 = _standard.initialStepClassifier2.clone() | ||
| initialStepClassifier2.vertices = "firstStepPrimaryVerticesBeforeMixing" | ||
| initialStepClassifier3 = _standard.initialStepClassifier3.clone() | ||
| initialStepClassifier3.vertices = "firstStepPrimaryVerticesBeforeMixing" | ||
|
|
||
|
|
||
| initialStep = _standard.initialStep.clone() | ||
|
|
||
| # Final sequence | ||
| InitialStep = cms.Sequence(initialStepTrackingRegions | ||
| +initialStepSeeds | ||
| +initialStepTrackCandidates | ||
| +initialStepTracks | ||
| +firstStepPrimaryVerticesBeforeMixing | ||
| +initialStepClassifier1*initialStepClassifier2*initialStepClassifier3 | ||
| +initialStep | ||
| ) | ||
|
|
||
| # all work is now done via fastSim era | ||
| from RecoTracker.IterativeTracking.InitialStep_cff import * |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and in a few more places, is there a reverse equivalent, along the following lines:
FastSimulation/Configuration will contain only the fastsim modifiers and by itself can not be used.
Instead then the standard include should change to Configuration.StandardSequences.Reconstruction_cff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering changing to just the standard includes as a seperate pull request. I wanted to minimize impact on other code (such as cmsDriver) as possible.