Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM code for the HLT_TripleMu_5_3_3_Mass3p8to60_DCA #20892

Merged
merged 2 commits into from Oct 27, 2017

Conversation

gkaratha
Copy link
Contributor

Dear Experts,

This commit is the DQM code for the HLT_TripleMu_5_3_3_Mass3p8to60_DCA. No new code wis introduced. Simple replication of old code. Thanks.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20892/1377

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gkaratha for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017

@gkaratha thanks !
please, update the title to something slightly more effective
please, quantify the increase in #bins

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23709/console Started: 2017/10/12 09:54

@gkaratha gkaratha changed the title Triplemu dca DQM code for the HLT_TripleMu_5_3_3_Mass3p8to60_DCA Oct 12, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@gkaratha
Copy link
Contributor Author

Dear Mia,

Thanks for your comments! I changed the name and the number of bins that i use is ~150 for plots (not counting denominator/numerator independently). Thanks.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20892/23709/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766764
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017 via email

@gkaratha
Copy link
Contributor Author

Dear Mia,

I think that the answer is ~450. (150 for numerator, 150 for denominator and 150 for efficiency). Thanks again.

Best,
George

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@mtosi
Copy link
Contributor

mtosi commented Oct 26, 2017

@davidlange6 @dmitrijus
can we proceed w/ the integration ?
thanks !

@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_10_0_X Oct 26, 2017
@cmsbuild cmsbuild modified the milestones: CMSSW_10_0_X, CMSSW_9_4_X Oct 26, 2017
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 45a2438 into cms-sw:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants