Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Zmu skim muon selector #20899

Merged
merged 1 commit into from Oct 11, 2017

Conversation

davidlange6
Copy link
Contributor

thanks to @rvenditti for the fix.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20899/1408

@davidlange6
Copy link
Contributor Author

please test

@davidlange6
Copy link
Contributor Author

merge

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23694/console Started: 2017/10/11 21:34

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DPGAnalysis/Skims

@cmsbuild, @GurpreetSinghChahal, @prebello, @fabozzi can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild merged commit ee08a95 into cms-sw:master Oct 11, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20899/23694/summary.html

There are some workflows for which there are errors in the baseline:
1000.0 step 3
10824.0 step 5
11624.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 2375134
  • DQMHistoTests: Total failures: 81
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2374898
  • DQMHistoTests: Total skipped: 155
  • DQMHistoTests: Total Missing objects: 0
  • Checked 97 log files, 10 edm output root files, 24 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Oct 12, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants