increase of pT threshold for photons to be considered for tau reconstruction and ID #20900
Conversation
Increase gamma Et threshold for tau reco&id
|
@roger-wolf, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @roger-wolf (Roger Wolf) for master. It involves the following packages: RecoTauTag/Configuration @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -80,12 +80,12 @@ | |||
| ## ByMediumIsolation | |||
| hpsPFTauDiscriminationByMediumIsolation = hpsPFTauDiscriminationByLooseIsolation.clone() | |||
| hpsPFTauDiscriminationByMediumIsolation.qualityCuts.isolationQualityCuts.minTrackPt = 0.8 | |||
| hpsPFTauDiscriminationByMediumIsolation.qualityCuts.isolationQualityCuts.minGammaEt = 0.8 | |||
| hpsPFTauDiscriminationByMediumIsolation.qualityCuts.isolationQualityCuts.minGammaEt = 1.0 | |||
There was a problem hiding this comment.
this change in threshold is applied here for all tau reconstruction: run1, phase-2, 2015-16, and the current pp of 2017.
Is this the intention or are you trying to mitigate the effects of the ECAL ZS/SR changes special for 2017 and this applies only to 2017?
There was a problem hiding this comment.
Hello,
we are aware that it is applied for tau reconstruction for all Eras; a couple words of explanation to make it more clear:
- The change has nothing to do with ECAL ZS/SR changes - it was checked with dedicated samples that the issue observed by Tau POG with low-Pt photons is not cured by the ZS/SR fix proposed by ECAL DPG.
- The issue is related to Run-2 data, i.e. was not observed during Run-1, but we suppose that CMSSW from 94X and newer release series will not be used to re-reconstruct Run-1 data. However, if such a re-reco is not impossible we can introduce a specialization for Run-1 - please let us know.
- It is intended that it consistently modifies reconstruction of Run-2 data. However, we are not aware of any plan of re-reconstruction of 2015 data with the 94X+ release series. What concerns 2016 80XLegacy re-miniAOD with 94X it is in fact foreseen that the re-miniAOD will consists of re-reco of taus with 2017-like setup.
- Taus for phase-2: it is fine that this modification is propagated there as we believe that it will help at high PU. However, tau reco for phase-2 is still worked on (for instance in the context of HGCAL and Physics TDRs) and additional changes can be expected.
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: dfa9787 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
On 10/12/17 12:00 AM, mbluj wrote:
Hello,
we are aware that it is applied for tau reconstruction for all Eras; a
couple words of explanation to make it more clear:
1. The change has nothing to do with ECAL ZS/SR changes - it was
checked with dedicated samples that the issue observed by Tau POG
with low-Pt photons is not cured by the ZS/SR fix proposed by ECAL DPG.
2. The issue is related to Run-2 data, i.e. was not observed during
Run-1, but we suppose that CMSSW from 94X and newer release series
will not be used to re-reconstruct Run-1 data. However, if such a
re-reco is not impossible we can introduce a specialization for
Run-1 - please let us know.
3. It is intended that it consistently modifies reconstruction of Run-2
data. However, we are not aware of any plan of re-reconstruction of
2015 data with the 94X+ release series. What concerns 2016 80XLegacy
re-miniAOD with 94X it is in fact foreseen that the re-miniAOD will
consists of re-reco of taus with 2017-like setup.
4. Taus for phase-2: it is fine that this modification is propagated
there as we believe that it will help at high PU. However, tau reco
for phase-2 is still worked on (for instance in the context of HGCAL
and Physics TDRs) and additional changes can be expected.
Thank you for the detailed explanation.
It looks like a solution covering all (without era specialization) is a
good one.
|
|
Comparison is ready Comparison Summary:
|
|
Dear all, from a coarse inspection of the millions of comparison plots I see differences which look as expected. Since both the decay mode reconstruction as well as the tauID are affected by the increase of the photon pT none of the plots is expected to look identical to the reference. On a representative Higgs and ttbar sample I see less photons for the isolation sum, this is expected. Also a slightly better energy resolution of the reconstructed taus has been reported by Michal. I know that @mbluj is planning to have a look into the comparisons as well, but he cannot promise to do so before late during today. Also @steggema and @isobelojalvo might want to comment on the output. Cheers, |
|
Dear Roger, All, |
|
I’m travelling and can’t check in great detail but everything I checked looks as expected, as I also read from the other responses, so sign off from my side.
Cheers,
Jan
On 12. Oct 2017, at 17:07, isobelojalvo <notifications@github.com<mailto:notifications@github.com>> wrote:
Dear Roger, All,
Thank you for getting this integrated so quickly. We do expect minor changes in the performance for the 1 prong and 1prong pi0 taus and from the plots I have seen they are following what has been shown in the offline studies. Perhaps @steggema<https://github.com/steggema> has a chance to take a look as well.
Cheers,
Isobel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20900 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzwI4Szn-ul8bEiPRPqwXXeJjkOEon4ks5srir_gaJpZM4P2BaM>.
|
|
Hello,
On Thu, Oct 12, 2017 at 4:12 PM, Roger Wolf ***@***.***> wrote:
Dear all,
from a coarse inspection of the millions of comparison plots I see
differences which look as expected.
Since both the decay mode reconstruction as well as the tauID are affected
by the increase of the photon pT none of the plots is expected to look
identical to the reference. On a representative Higgs and ttbar sample I
see less photons for the isolation sum, this is expected. Also a slightly
better energy resolution of the reconstructed taus has been reported by
Michal.
I know that @mbluj <https://github.com/mbluj> is planning to have a look
into the comparisons as well, but he cannot promise to do so before late
during today. Also @steggema <https://github.com/steggema> and
@isobelojalvo <https://github.com/isobelojalvo> might want to comment on
the output.
I would like to let you know that differences in plots I inspected look as
expected. This confirms observations by other experts.
Best,
Michał
|
|
From (e.g.) the SinglePh2017B wf run during the jenkins tests the effect of the modified cuts is clearly visible:
Pizeros are mostly removed in the barrel:
All the discriminators by isolation are more peaked at one (as there are less photon around in the isolation cone):
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
merge |
Hi Slava, Andrea,
this is a PR to mitigate discrepancies in the MC description of PF photons used for tau reconstruction and ID. To mitigate this issue the pT for PF photons to be considered for tau reconstruction and ID is raised from 0.5 to 1 GeV. The implementation and validation has been provided by @mbluj. I post his initial PR description below (*). These are pure changes on configuration level. We do expect changed in the validation plots (see below). Usual unit tests perform fine. We would like to have this still being part of the upcoming 94X production release!
Thanx a lot!
Cheers,
Roger
(*)
As title of the PR says, this is a set of modification of python cfi/cff files to increase Et threshold of PF-photons used in tau reconstruction and identification from 0.5 to 1GeV. The modification is expected to have the following effects:
Expected changes are summarized in slides which can be found here: