Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase of pT threshold for photons to be considered for tau reconstruction and ID #20900

Merged
merged 2 commits into from Oct 17, 2017
Merged

increase of pT threshold for photons to be considered for tau reconstruction and ID #20900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83f1b99
Increase Gamma Et threshold for tau reco and id to 1GeV
mbluj Oct 10, 2017
dfa9787
Merge pull request #60 from mbluj/photonPtGt1GeV
roger-wolf Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions RecoTauTag/Configuration/python/HPSPFTaus_cff.py
View file
Open in desktop
Expand Up @@ -80,12 +80,12 @@
## ByMediumIsolation
hpsPFTauDiscriminationByMediumIsolation = hpsPFTauDiscriminationByLooseIsolation.clone()
hpsPFTauDiscriminationByMediumIsolation.qualityCuts.isolationQualityCuts.minTrackPt = 0.8
hpsPFTauDiscriminationByMediumIsolation.qualityCuts.isolationQualityCuts.minGammaEt = 0.8
hpsPFTauDiscriminationByMediumIsolation.qualityCuts.isolationQualityCuts.minGammaEt = 1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change in threshold is applied here for all tau reconstruction: run1, phase-2, 2015-16, and the current pp of 2017.
Is this the intention or are you trying to mitigate the effects of the ECAL ZS/SR changes special for 2017 and this applies only to 2017?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
we are aware that it is applied for tau reconstruction for all Eras; a couple words of explanation to make it more clear:

  1. The change has nothing to do with ECAL ZS/SR changes - it was checked with dedicated samples that the issue observed by Tau POG with low-Pt photons is not cured by the ZS/SR fix proposed by ECAL DPG.
  2. The issue is related to Run-2 data, i.e. was not observed during Run-1, but we suppose that CMSSW from 94X and newer release series will not be used to re-reconstruct Run-1 data. However, if such a re-reco is not impossible we can introduce a specialization for Run-1 - please let us know.
  3. It is intended that it consistently modifies reconstruction of Run-2 data. However, we are not aware of any plan of re-reconstruction of 2015 data with the 94X+ release series. What concerns 2016 80XLegacy re-miniAOD with 94X it is in fact foreseen that the re-miniAOD will consists of re-reco of taus with 2017-like setup.
  4. Taus for phase-2: it is fine that this modification is propagated there as we believe that it will help at high PU. However, tau reco for phase-2 is still worked on (for instance in the context of HGCAL and Physics TDRs) and additional changes can be expected.

hpsPFTauDiscriminationByMediumIsolation.Prediscriminants.preIso.Producer = cms.InputTag("hpsPFTauDiscriminationByMediumChargedIsolation")
## ByTightIsolation
hpsPFTauDiscriminationByTightIsolation = hpsPFTauDiscriminationByLooseIsolation.clone()
hpsPFTauDiscriminationByTightIsolation.qualityCuts.isolationQualityCuts.minTrackPt = 0.5
hpsPFTauDiscriminationByTightIsolation.qualityCuts.isolationQualityCuts.minGammaEt = 0.5
hpsPFTauDiscriminationByTightIsolation.qualityCuts.isolationQualityCuts.minGammaEt = 1.0
hpsPFTauDiscriminationByTightIsolation.Prediscriminants.preIso.Producer = cms.InputTag("hpsPFTauDiscriminationByTightChargedIsolation")
## ByLooseIsolationDBSumPtCorr
hpsPFTauDiscriminationByLooseIsolationDBSumPtCorr = hpsPFTauDiscriminationByLooseIsolation.clone(
Expand Down Expand Up @@ -128,7 +128,7 @@
Prediscriminants = requireDecayMode.clone()
)
hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minTrackPt = 0.5
hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minGammaEt = 0.5
hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minGammaEt = 1.0
## ByMediumCombinedIsolationDBSumPtCorr
hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr = hpsPFTauDiscriminationByMediumIsolationDBSumPtCorr.clone(
ApplyDiscriminationByTrackerIsolation = True,
Expand All @@ -140,7 +140,7 @@
Prediscriminants = requireDecayMode.clone()
)
hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minTrackPt = 0.5
hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minGammaEt = 0.5
hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minGammaEt = 1.0
## ByTightCombinedIsolationDBSumPtCorr
hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr = hpsPFTauDiscriminationByTightIsolationDBSumPtCorr.clone(
ApplyDiscriminationByTrackerIsolation = True,
Expand All @@ -152,7 +152,7 @@
Prediscriminants = requireDecayMode.clone()
)
hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minTrackPt = 0.5
hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minGammaEt = 0.5
hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr.qualityCuts.isolationQualityCuts.minGammaEt = 1.0
## ByLooseChargedIsolation
hpsPFTauDiscriminationByLooseChargedIsolation = hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr.clone(
ApplyDiscriminationByECALIsolation = False
Expand Down
2 changes: 1 addition & 1 deletion RecoTauTag/RecoTau/python/HLTPFRecoTauQualityCuts_cfi.py
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
maxTransverseImpactParameter = cms.double(0.03), # Should in general be disabled at HLT (PV is sometimes missing)
minTrackVertexWeight = cms.double(-1), # Should in general be disabled at HLT (PV is sometimes missing)
minTrackHits = cms.uint32(3), # total track hits
minGammaEt = cms.double(0.5), # filter PFgammas below given Pt
minGammaEt = cms.double(1.0), # filter PFgammas below given Pt
useTracksInsteadOfPFHadrons = cms.bool(False), # if true, use generalTracks, instead of PFChargedHadrons
),
isolationQualityCuts = cms.PSet(
Expand Down
8 changes: 4 additions & 4 deletions RecoTauTag/RecoTau/python/PFRecoTauChargedHadronBuilderPlugins_cfi.py
View file
Open in desktop
Expand Up @@ -31,8 +31,8 @@
dRmergePhotonWrtOther = cms.double(0.005),
minBlockElementMatchesPhoton = cms.int32(2),
maxUnmatchedBlockElementsPhoton = cms.int32(1),
minMergeNeutralHadronEt = cms.double(0.),
minMergeGammaEt = cms.double(0.),
minMergeNeutralHadronEt = cms.double(1.0),
minMergeGammaEt = cms.double(1.0),
minMergeChargedHadronPt = cms.double(100.)
)

Expand All @@ -47,8 +47,8 @@
qualityCuts = PFTauQualityCuts,
dRmergeNeutralHadron = cms.double(0.10),
dRmergePhoton = cms.double(0.05),
minMergeNeutralHadronEt = cms.double(0.),
minMergeGammaEt = cms.double(0.),
minMergeNeutralHadronEt = cms.double(1.0),
minMergeGammaEt = cms.double(1.0),
minMergeChargedHadronPt = cms.double(100.)
)

Expand Down
4 changes: 2 additions & 2 deletions RecoTauTag/RecoTau/python/PFRecoTauQualityCuts_cfi.py
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
minTrackVertexWeight = cms.double(-1.), # Tracks weight in vertex
minTrackPixelHits = cms.uint32(0), # pixel-only hits
minTrackHits = cms.uint32(3), # total track hits
minGammaEt = cms.double(0.5), # filter PFgammas below given Pt
minGammaEt = cms.double(1.0), # filter PFgammas below given Pt
#useTracksInsteadOfPFHadrons = cms.bool(False), # if true, use generalTracks, instead of PFChargedHadrons
minNeutralHadronEt = cms.double(30.)
),
Expand All @@ -36,7 +36,7 @@
minTrackVertexWeight = cms.double(-1.), # Tracks weight in vertex
minTrackPixelHits = cms.uint32(0), # pixel-only hits
minTrackHits = cms.uint32(3), # total track hits
minGammaEt = cms.double(0.5) # filter PFgammas below given Pt
minGammaEt = cms.double(1.0) # filter PFgammas below given Pt
#useTracksInsteadOfPFHadrons = cms.bool(False), # if true, use generalTracks, instead of PFChargedHadrons
),
# The central definition of primary vertex source.
Expand Down
2 changes: 1 addition & 1 deletion RecoTauTag/RecoTau/python/PFRecoTauTagInfoProducer_cfi.py
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@
ChargedHadrCand_tkminPt = cms.double(0.5), # charged PF objects
tkminPt = cms.double(0.5), # track (non-PF) objects
NeutrHadrCand_HcalclusMinEt = cms.double(1.0), # PF neutral hadrons (HCAL)
GammaCand_EcalclusMinEt = cms.double(0.5), # PF gamma candidates (ECAL)
GammaCand_EcalclusMinEt = cms.double(1.0), # PF gamma candidates (ECAL)

# The size of the delta R cone used to collect objects from the jet
ChargedHadrCand_AssociationCone = cms.double(0.8),
Expand Down
44 changes: 22 additions & 22 deletions RecoTauTag/RecoTau/python/RecoTauPiZeroBuilderPlugins_cfi.py
View file
Open in desktop
Expand Up @@ -60,8 +60,8 @@
modStrips = strips.clone(
plugin = cms.string('RecoTauPiZeroStripPlugin2'),
applyElecTrackQcuts = cms.bool(False),
minGammaEtStripSeed = cms.double(0.5),
minGammaEtStripAdd = cms.double(0.),
minGammaEtStripSeed = cms.double(1.0),
minGammaEtStripAdd = cms.double(1.0),
minStripEt = cms.double(1.0),
updateStripAfterEachDaughter = cms.bool(False),
maxStripBuildIterations = cms.int32(-1)
Expand All @@ -70,24 +70,24 @@
# Produce a "strips" of photons
# with no track quality cuts applied to PFElectrons
# and eta x phi size of strip increasing for low pT photons
modStrips2 = strips.clone(
plugin = cms.string('RecoTauPiZeroStripPlugin3'),
applyElecTrackQcuts = cms.bool(False),
minGammaEtStripSeed = cms.double(0.5),
minGammaEtStripAdd = cms.double(0.),
minStripEt = cms.double(0.5),
# CV: parametrization of strip size in eta and phi determined by Yuta Takahashi,
# chosen to contain 95% of photons from tau decays
stripEtaAssociationDistance = cms.PSet(
function = cms.string("TMath::Min(0.15, TMath::Max(0.05, [0]*TMath::Power(pT, -[1])))"),
par0 = cms.double(1.97077e-01),
par1 = cms.double(6.58701e-01)
),
stripPhiAssociationDistance = cms.PSet(
function = cms.string("TMath::Min(0.3, TMath::Max(0.05, [0]*TMath::Power(pT, -[1])))"),
par0 = cms.double(3.52476e-01),
par1 = cms.double(7.07716e-01)
),
updateStripAfterEachDaughter = cms.bool(False),
maxStripBuildIterations = cms.int32(-1)
modStrips2 = strips.clone(
plugin = cms.string('RecoTauPiZeroStripPlugin3'),
applyElecTrackQcuts = cms.bool(False),
minGammaEtStripSeed = cms.double(1.0),
minGammaEtStripAdd = cms.double(1.0),
minStripEt = cms.double(1.0),
# CV: parametrization of strip size in eta and phi determined by Yuta Takahashi,
# chosen to contain 95% of photons from tau decays
stripEtaAssociationDistance = cms.PSet(
function = cms.string("TMath::Min(0.15, TMath::Max(0.05, [0]*TMath::Power(pT, -[1])))"),
par0 = cms.double(1.97077e-01),
par1 = cms.double(6.58701e-01)
),
stripPhiAssociationDistance = cms.PSet(
function = cms.string("TMath::Min(0.3, TMath::Max(0.05, [0]*TMath::Power(pT, -[1])))"),
par0 = cms.double(3.52476e-01),
par1 = cms.double(7.07716e-01)
),
updateStripAfterEachDaughter = cms.bool(False),
maxStripBuildIterations = cms.int32(-1)
)