Fill time and uncertainties for slimmed primary vertices

[lgray]

Fill timing information for miniaod slimmed vertices.

[lgray]

@cmsbuild please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[lgray]

@bendavid

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20911/1440

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20911/1440/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20911/1440/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[perrotta]

@lgray please apply code checks so that tests can be started

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20911/1451

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23766/console Started: 2017/10/14 08:23

[cmsbuild]

+1
Tested at: d89db92
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20911/23766/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
42f293a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20911/23766/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20911/23766/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20911/23766/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2767139
• DQMHistoTests: Total failures: 101
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2766867
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[slava77]

Fill timing information for miniaod slimmed vertices.

@lgray
please provide estimates for size on disk for current (2017) data or MC.
If it's visibly increasing (e.g. more than 10 bytes per event in ttbar PU35 or similar), the change should be implemented only in context of phase-2 timing workflows.

[lgray]

@slava77 The matrix in the vertex class was already larger, just not being filled (so it was likely zeroes). In the case where there is no timing that does not change. Essentially your requested alteration is already there.

[slava77]

On 10/17/17 11:39 AM, Lindsey Gray wrote: @slava77 <https://github.com/slava77> The matrix in the vertex class was already larger, just not being filled (so it was likely zeroes). In the case where there is no timing that does not change. Essentially your requested alteration is already there.

right, thanks for the reminder that the underlying storage is the same size suitable for 4D. OK, assuming we don't fill some random numbers with this PR.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20911 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbgRIxMUOEz1s1h_q9yl0s6DWKkkrks5stPRQgaJpZM4P3xHh>.

[slava77]

+1

for #20911 d89db92

• complete the assignment of vertex parameters for slimmed vertices to include the time dimension
• jenkins tests pass and comparisons show no differences (all tested workflows still have offlineSlimmedPrimaryVertices using without time in the fit)

[slava77]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

+1
(no significant change in relval file size, as expected)

[davidlange6]

merge