Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1TOffline DQM - add efficiency flag to efficiency ME - 92x #20924

Merged

Conversation

thomreis
Copy link
Contributor

Add efficiency flag to L1T offline DQM efficiency ME to avoid plots being normalised in the GUI.

@thomreis
Copy link
Contributor Author

backport of #20923

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Oct 16, 2017

please test

@rekovic
Copy link
Contributor

rekovic commented Oct 16, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23779/console Started: 2017/10/16 10:12

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20924/23779/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1978338
  • DQMHistoTests: Total failures: 14535
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1963631
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 9 edm output root files, 23 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 702e7fa into cms-sw:CMSSW_9_2_X Oct 25, 2017
@thomreis thomreis deleted the l1toffline-dqm-efficiency-flag-92x branch October 25, 2017 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants