Excluded gluons and quarks from Geant4 tracking #20931
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
-1 |
|
@davidlange6 , this PR does not include exceptions but is improving LogInfo and LogWarnings, that may be useful indeed. I will contact with generator peoples but would not expect any fast solutions because this is concern of various generator developers. So, it is worse to merge this PR. |
|
@davidlange6 , may be this can be merged? |
|
@davidlange6 , a reference on the talk is added to this PR description. The discussion with generator conveners is started, if any modification will be needed it will be implemented in the new PR. |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
comparison-available
tests-approved
tests-pending
labels
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
Enabled exclusion of gluons and quarks from Geant4 tracking. Normally this should not happens, if event generator providing correct HepMC status code, but unfortunately, this was observed for some XeXe generators. The problem is discussed at SIM meeting during December CMS week: https://indico.cern.ch/event/684826/contributions/2812929/attachments/1570329/2476913/FullSimDec.pdf
Also std::abs is used in this class instead of fabs, clean-up of internal methods: pdg code is used instead of pointer, LogInfo and LogWarnings are revised and extended.
Should not affect results.