Run2-alca102 Modify the calibration code involving MIP studies

[bsunanda]

hcal geometry code is corrected in view of debugging these applications

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20983/1576

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20983/1576/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20983/1576/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20983/1577

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos
Calibration/IsolatedParticles

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23903/console Started: 2017/10/20 20:28

[cmsbuild]

+1
Tested at: 2fb2869
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20983/23903/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
08b510f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20983/23903/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20983/23903/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20983/23903/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
10024.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2672985
• DQMHistoTests: Total failures: 98
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2672717
• DQMHistoTests: Total skipped: 170
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[lpernie]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1