Genxsec contact comments93 x

[efeyazgan]

backport of #20952

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20999/1611

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20999/1611/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20999/1611/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[slava77]

-1

bad submission; looks like it was supposed to be submitted to 93X instead of master

[cmsbuild]

Pull request #20999 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

[efeyazgan]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23979/console Started: 2017/10/25 12:12

[cmsbuild]

+1
Tested at: d671b12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20999/23979/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cb42c32
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20999/23979/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20999/23979/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20999/23979/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2708283
• DQMHistoTests: Total failures: 228
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2707868
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 9 edm output root files, 26 DQM output files

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1