New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition #2101
add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition #2101
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC. add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition It involves the following packages: GeneratorInterface/LHEInterface @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks. |
…ing is less cumbersome
Builds fine and tests pass. However, I don't think the tests I ran test any of these changes. I put a throw exception at a random point in LHEReader.cc and the tests all still pass.
I'll keep an eye on 2097 and discuss this at the release planning meeting on Tuesday. |
@mark-grimes Matrix tests will not catch any issue with this. The LHE reader and the capability to save weights was already tested and validated in 70X/62X/53X. |
merge Discussed in the release planning meeting and agreed to accept. |
add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition
Rebase of #2097 to CMSSW 62X_SLHC
Had to also bring in the commits from #1020, since they did not make it into the SLHC branch.