Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition #2101

Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 21, 2014

Rebase of #2097 to CMSSW 62X_SLHC

Had to also bring in the commits from #1020, since they did not make it into the SLHC branch.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition

It involves the following packages:

GeneratorInterface/LHEInterface
SimDataFormats/GeneratorProducts

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @kknb1056 you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #2101 was updated. @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please check and sign again.

@mark-grimes
Copy link

Builds fine and tests pass. However, I don't think the tests I ran test any of these changes. I put a throw exception at a random point in LHEReader.cc and the tests all still pass.
@lgray, you say in request 2097 (the same thing but on CMSSW_7) that you've checked this by writing the file read in, have you tried this in 6_2_X_SLHC or is there likely to be no difference? Otherwise, do you know of a test I can run that will check this? I tried with:

runTheMatrix.py -j 6 -w upgrade -l 3300,3400,4100,4400,40001,50002,60002,60001,4502,4500,5001,15001,50001

I'll keep an eye on 2097 and discuss this at the release planning meeting on Tuesday.

@lgray
Copy link
Contributor Author

lgray commented Jan 24, 2014

@mark-grimes Matrix tests will not catch any issue with this. The LHE reader and the capability to save weights was already tested and validated in 70X/62X/53X.

@mark-grimes
Copy link

merge

Discussed in the release planning meeting and agreed to accept.

cmsbuild added a commit that referenced this pull request Jan 28, 2014
add originalXWGTUP() to LHEEvent and LHEEventProduct 62X_SLHC edition
@cmsbuild cmsbuild merged commit 3bbde01 into cms-sw:CMSSW_6_2_X_SLHC Jan 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants