Run2-sim18 Do the bug fix for ECal shower profile correction to 9_2_X (back porting from 9_4_X)

[bsunanda]

Correctly calculating depth along crystal

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_9_2_X.

It involves the following packages:

SimCalorimetry/EcalSimAlgos
SimDataFormats/CaloHit
SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23972/console Started: 2017/10/24 20:14

[cmsbuild]

+1
Tested at: 9db7478
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21012/23972/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5b5452e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21012/23972/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21012/23972/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21012/23972/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 11100 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1982739
• DQMHistoTests: Total failures: 45814
• DQMHistoTests: Total nulls: 72
• DQMHistoTests: Total successes: 1936681
• DQMHistoTests: Total skipped: 172
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 9 edm output root files, 23 DQM output files

[civanch]

@bsunanda , how you make the PR: direct copy from 9_3_X or by edition of the code? I am asking because code-checker add many useful modifications, so difficult to control real modifications.

[bsunanda]

@cmsbuild I compared with the changes in 9_4_X. I believe the code-checker changes are also included for the classes which are modified here.

[civanch]

+1
I believe that a copy from 9_4 should work for 9_2

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1