Add a fast version of existing 2-prong D trigger filter and a new 3-prong trigger filter in 10_0_X

[boundino]

new D trigger modules

[cmsbuild]

@boundino, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21017/1640

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21017/1640/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-21017/1640/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21017/1641

[cmsbuild]

A new Pull Request was created by @boundino (Jing Wang) for master.

It involves the following packages:

HLTrigger/btau

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @Martin-Grunewald, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

Some questions:

• Where/when was this discussed in a TSG meeting (link?)
• Is this for 2017 (pp) data taking? Then it is too late!
• The code of the different new filters looks strongly overlapping, also with existing filters of a similar name, so a more generic but single filter implementation should be coded.

[FHead]

For the first two points,

• The TSG link is here https://indico.cern.ch/event/675484/#9-a-new-d-meson-filter-for-hlt
• It is for the 2017 pp reference run (5 TeV) starting end of November.

I'll let @boundino comment on the code.

[boundino]

Hello Martin,



As Yi mentioned, the new filters were discussed in the last TSG meeting on Monday and
they are meant to be used in the pp reference data run that will start in the end of November.
This pp reference run was unfortunately scheduled very recently and made our timeline very complicated.

The new filter HLTDisplacedtktkVtxProducerFast is an improvement of the filter HLTDisplacedtktkVtxProducer, that had timing problems during the last pPb and PbPb data taking periods. We implemented the suggestions that 
Slava gave us at the time and we produced a new faster version. As you correctly pointed out, HLTDisplacedtktkVtxProducerFast and HLTDisplacedtktkVtxProducer, basically perform the same type of reconstruction. We would still like to keep both versions to make sure we have a solid and tested backup. This solution was blessed by TSG also to make sure that other HLT paths that might currently use the old producer would not be affected by the change.

Please let us know what you think,

Thank you very much for your help and suggestions,
Cheers,
Jing, Gian Michele

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21017/2135

[cmsbuild]

Pull request #21017 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21017/2136

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24655/console Started: 2017/11/23 15:43

[cmsbuild]

+1
Tested at: e150ca7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21017/24655/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a3cf1a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21017/24655/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21017/24655/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21017/24655/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.890000000058 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1