Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against missing track info in MiniAOD #21019

Merged
merged 3 commits into from Oct 27, 2017
Merged

Protect against missing track info in MiniAOD #21019

merged 3 commits into from Oct 27, 2017

Conversation

ahinzmann
Copy link
Contributor

Backport of #20740

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Oct 25, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2017 •
edited

A new Pull Request was created by @ahinzmann for CMSSW_9_2_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @yslai, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23983/console Started: 2017/10/25 18:56

@cmsbuild
Copy link
Contributor

-1

Tested at: f8c761f

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de1c101
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23983/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23983/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23983/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error
136.788 step1 
DAS Error
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Wed Oct 25 20:17:47 2017-date Wed Oct 25 20:13:20 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02495/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-10-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Oct 25 20:17:47 2017-date Wed Oct 25 20:13:20 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 25 20:17:47 2017-date Wed Oct 25 20:13:20 2017 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2e34v22 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --fileout file:RelVal_Raw_2e34v22_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Wed Oct 25 20:20:32 2017-date Wed Oct 25 20:15:46 2017 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02495/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-10-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Oct 25 20:20:32 2017-date Wed Oct 25 20:15:46 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_DATA.root --fileout file:RelVal_Raw_2e34v22_DATA_HLT_RECO.root : FAILED - time: date Wed Oct 25 20:20:32 2017-date Wed Oct 25 20:15:46 2017 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de1c101
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23983/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23983/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23990/console Started: 2017/10/26 07:19

@cmsbuild
Copy link
Contributor

+1
Tested at: f8c761f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23990/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de1c101
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23990/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23990/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21019/23990/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1982671
  • DQMHistoTests: Total failures: 29476
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1953023
  • DQMHistoTests: Total skipped: 172
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 9 edm output root files, 23 DQM output files

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4cf75fa into cms-sw:CMSSW_9_2_X Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahinzmann @cmsbuild @perrotta @davidlange6