Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more explanation to GeneratorInterface/GenFilters/interface/TotalKinematicsFilter.h #2103

Merged
merged 1 commit into from Jan 21, 2014

Conversation

andreh7
Copy link

@andreh7 andreh7 commented Jan 21, 2014

Added more details about what this filter does in the comments. No code changes.

This pull request supersedes pull request #2039

ktf added a commit that referenced this pull request Jan 21, 2014
Documentation -- Added more explanation to GeneratorInterface/GenFilters/interface/TotalKinematicsFilter.h
@ktf ktf merged commit b99c157 into cms-sw:CMSSW_7_1_X Jan 21, 2014
@ktf
Copy link
Contributor

ktf commented Jan 21, 2014

No need to run tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andreh7 for CMSSW_7_1_X.

added more explanation to GeneratorInterface/GenFilters/interface/TotalKinematicsFilter.h

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vciulli
Copy link
Contributor

vciulli commented May 27, 2014

Why this appeared as a new pull if it was merged and closed months ago?

@ktf
Copy link
Contributor

ktf commented May 27, 2014

We are cleaning up bypassed pull requests so that they have correct labels. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants