Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making cfg compatible with py8 230 #21047

Merged
merged 2 commits into from Nov 3, 2017

Conversation

alberto-sanchez
Copy link
Member

@alberto-sanchez alberto-sanchez commented Oct 27, 2017

new contribution was added to Onia processes. This should take care of that

please test workflow 111.0

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21047/1680

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master.

It involves the following packages:

Configuration/Generator

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor

please test workflow 111.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24020/console Started: 2017/10/27 20:50

@alberto-sanchez
Copy link
Member Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21047/24020/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 120
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838151
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21047/1756

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Pull request #21047 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

@alberto-sanchez
Copy link
Member Author

hi @davidlange6 - I have do so. Yes this could impact several configs.

@perrozzi
Copy link
Contributor

perrozzi commented Nov 2, 2017

please test workflow 111.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24117/console Started: 2017/11/02 09:15

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21047/24117/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 122
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838149
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@perrozzi
Copy link
Contributor

perrozzi commented Nov 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f65a955 into cms-sw:master Nov 3, 2017
@alberto-sanchez alberto-sanchez deleted the UpdateToPy8230-cfgs branch May 11, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants