fix for asan build #21082
Merged
fix for asan build #21082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge
On 30 Oct 2017, at 17:11, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote:
This PR fixes the build error we get with ASAN IBs
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc<http://CSCTriggerPrimitivesReader.cc>: In member function 'void CSCTriggerPrimitivesReader::drawCompHistos()':
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=]
void CSCTriggerPrimitivesReader::drawCompHistos() {
^~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: note: directive argument in the range [1, 2147483647]
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2779<http://csctriggerprimitivesreader.cc:2779>:13: note: 'snprintf' output between 6 and 15 bytes into a destination of size 7
snprintf(pagenum, sizeof(pagenum), "- %d -", page); t.DrawText(0.9, 0.02, pagenum);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=]
void CSCTriggerPrimitivesReader::drawCompHistos() {
^~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: note: directive argument in the range [1, 2147483647]
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2831<http://csctriggerprimitivesreader.cc:2831>:13: note: 'snprintf' output between 6 and 15 bytes into a destination of size 7
snprintf(pagenum, sizeof(pagenum), "- %d -", page); t.DrawText(0.9, 0.02, pagenum);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=]
void CSCTriggerPrimitivesReader::drawCompHistos() {
^~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: note: directive argument in the range [1, 2147483647]
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2882<http://csctriggerprimitivesreader.cc:2882>:13: note: 'snprintf' output between 6 and 15 bytes into a destination of size 7
snprintf(pagenum, sizeof(pagenum), "- %d -", page); t.DrawText(0.9, 0.02, pagenum);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=]
void CSCTriggerPrimitivesReader::drawCompHistos() {
^~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: note: directive argument in the range [1, 2147483647]
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2934<http://csctriggerprimitivesreader.cc:2934>:13: note: 'snprintf' output between 6 and 15 bytes into a destination of size 7
snprintf(pagenum, sizeof(pagenum), "- %d -", page); t.DrawText(0.9, 0.02, pagenum);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=]
void CSCTriggerPrimitivesReader::drawCompHistos() {
^~~~~~~~~~~~~~~~~~~~~~~~~~
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2696<http://csctriggerprimitivesreader.cc:2696>:6: note: directive argument in the range [1, 2147483647]
L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc:2985<http://csctriggerprimitivesreader.cc:2985>:13: note: 'snprintf' output between 6 and 15 bytes into a destination of size 7
snprintf(pagenum, sizeof(pagenum), "- %d -", page); t.DrawText(0.9, 0.02, pagenum);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
…________________________________
You can view, comment on, or merge this pull request online at:
#21082
Commit Summary
* fix for asan build
File Changes
* M L1Trigger/CSCTriggerPrimitives/test/CSCTriggerPrimitivesReader.cc<https://github.com/cms-sw/cmssw/pull/21082/files#diff-0> (14)
Patch Links:
* https://github.com/cms-sw/cmssw/pull/21082.patch
* https://github.com/cms-sw/cmssw/pull/21082.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#21082>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywxswxJiXM0QU9Rhj_cy9nRj4W2Lpks5sxfUCgaJpZM4QLcL9>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build error we get with ASAN IBs