Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hltdqm offline top pag #2111

Merged
merged 8 commits into from Feb 6, 2014
Merged

Hltdqm offline top pag #2111

merged 8 commits into from Feb 6, 2014

Conversation

ebouvier
Copy link

Resubmitting #1795 as discussed in the dqm meeting

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebouvier for CMSSW_7_1_X.

Hltdqm offline top pag

It involves the following packages:

DQMOffline/Trigger

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2111/23/summary.html

@deguio
Copy link
Contributor

deguio commented Jan 22, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf
ktf reviewed Jan 22, 2014
View reviewed changes
DQMOffline/Trigger/src/TopSingleLeptonHLTOfflineDQM.cc
const string& moduleLabelElec(moduleLabels[kElec]);
const string moduleTypeElec(hltConfig.moduleType(moduleLabelElec));
const unsigned int filterIndexElec(triggerEventWithRefsHandle->filterIndex(edm::InputTag(moduleLabelElec,"","HLT")));
/* cout << " Filter in slot " << kElec << " - label/type " << moduleLabelElec << "/" << moduleTypeElec << endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop cout.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And drop commented code.

@cmsbuild
Copy link
Contributor

Pull request #2111 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2111/43/summary.html

@ebouvier
Copy link
Author

ebouvier commented Feb 3, 2014

Dear all,
I was wondering what is the current status of all the checks ?
Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

Pull request #2111 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2111/8/summary.html

@ebouvier
Copy link
Author

ebouvier commented Feb 3, 2014

Dear all,
Looking at the log files, it seems that there's a crash during the das query: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2111/8/runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step1_dasquery.log
so that my code couldn't be tested.
Please, @deguio, could you run it manually ?
Cheers,

@ghost
Copy link

ghost commented Feb 3, 2014

Hi, I re-launched the tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2111/12/summary.html

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@deguio
Copy link
Contributor

deguio commented Feb 5, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 6, 2014
@ktf
Merge pull request #2111 from ebouvier/HLTDQMOfflineTopPAG
9167171 
DQM updates -- Hltdqm offline top pag
@ktf ktf merged commit 9167171 into cms-sw:CMSSW_7_1_X Feb 6, 2014
@ebouvier ebouvier mentioned this pull request Feb 6, 2014
Closed
@nclopezo nclopezo added this to the CMSSW_7_1_0_pre4 milestone Feb 24, 2014
@nclopezo nclopezo removed this from the CMSSW_7_1_0_pre3 milestone Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@ebouvier ebouvier deleted the HLTDQMOfflineTopPAG branch September 10, 2014 13:21
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
@cmsbuild
Merge pull request cms-sw#2111 from smuzaffar/new-external-utm
b66c184 
added new external UTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ebouvier @cmsbuild @deguio @ktf @nclopezo