Added ResonanceDecayFilter:wzAsEquivalent setting to Pythia8Interface. #21132
Conversation
|
The code-checks are being triggered in jenkins. |
|
please test |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21132/1763 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21132/1763/git-diff.patch You can run |
|
@acarvalh please apply the patch suggested above |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @acarvalh (acarvalh) for master. It involves the following packages: GeneratorInterface/Pythia8Interface @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
|
||
| int mid = p.mother1()>0 ? std::abs(process[p.mother1()].id()) : 0; | ||
|
|
||
| //if no list of mothers is provided, then all particles | ||
| //in hard process and resonance decays are counted together | ||
| bool validMother = mothers_.size() ? false : true; | ||
| bool validMother = mothers_.empty(); |
There was a problem hiding this comment.
are you sure you have not inverted the logic here?
There was a problem hiding this comment.
(probably not, just make sure)
There was a problem hiding this comment.
@perozzi yes, I'm sure: !size() = empt().
There was a problem hiding this comment.
hi @acarvalh - if this line is correct, then the loop just below is not needed. perhaps it should really be
bool validMother=false?[in fact the declaration of validMother can be avoided trivially]
|
Dear all thank you |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
+1 |
To decay H inclusivelly to a pair of gauge bosons
@kandrosov