Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResonanceDecayFilter:wzAsEquivalent setting for Pythia8Interface (backport 7_1_X) #30309

Conversation

kandrosov
Copy link
Contributor

PR description:

Added ResonanceDecayFilter:wzAsEquivalent setting to Pythia8Interface.

PR validation:

code compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is port of #21132 for 7_1_X.
It is needed to produce 2016 HH->bbVV samples to decay H inclusively to a pair of gauge bosons.

@acarvalh

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kandrosov (Konstantin Androsov) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jun 19, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: eba483b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e309d/7209/summary.html
CMSSW: CMSSW_7_1_X_2020-06-14-0000
SCRAM_ARCH: slc6_amd64_gcc481

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e309d/7209/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 682523
  • DQMHistoTests: Total failures: 2630
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 679519
  • DQMHistoTests: Total skipped: 374
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
  • Checked 44 log files, 4 edm output root files, 11 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Jun 20, 2020

@silviodonato There are many DQM failures but seem not to be related to GEN. Is it expected?

@silviodonato
Copy link
Contributor

@qliphy see #29365

@qliphy
Copy link
Contributor

qliphy commented Jun 20, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 61ec43d into cms-sw:CMSSW_7_1_X Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants