New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and modernize SeedingLayerSetsBuilder #21138
Merged
cmsbuild
merged 23 commits into
cms-sw:master
from
makortel:cleanupSeedingLayerSetsBuilder
Nov 14, 2017
Merged
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
583ab90
Remove SeedingLayerSetsBuilder::layers() as unused and obsolete
makortel 87deccb
Remove CosmicTrackingRegion::hits(.., ctfseeding::SeedingLayer*) as u…
makortel 3cbaeaf
Remove unnecessary includes of SeedingLayer.h
makortel 0d873a8
Remove all functionality from SeedingLayer as unused and obsolete
makortel a7f9c13
Remove forward declaration
makortel 97cd12e
Move SeedingLayerSetsHits construction to SeedingLayerSetsBuilder
makortel e6b9ddf
Minor modernization
makortel 551574a
Deliver also DetLayer vector via pointer for consistency
makortel c6dcf57
Remove SeedingLayer.h as unnecessary, move enum to more general Track…
makortel f3de976
Remove unnecessary mutable
makortel ebfb745
Use unique_ptr
makortel 57af369
Simplify updating from EventSetup
makortel 935b148
Move SeedingLayersEDProducer to fillDescriptions
makortel d52a98b
Unify layer naming with iterative tracking and reduce copy-paste
makortel 2a09975
Call updateEventSetup inside hits() in SeedingLayerSetsBuilder
makortel dba7e34
Fix cosmics
makortel fdb5f67
Change TrackerDetSide to enum class
makortel d136fc5
Remove spurious ;
makortel 835e3ae
Remove duplicated #include
makortel 3e37411
Add back shink_to_fit
makortel c781b5d
Streamline the strip mono hit definition in MTV
makortel 38e3f33
Hack for conversion seeding layers
makortel 733226a
Fix typo
makortel File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#ifndef DataFormats_TrackerCommon_TrackerDetSide_H | ||
#define DataFormats_TrackerCommon_TrackerDetSide_H | ||
|
||
struct TrackerDetSide { | ||
enum Side { Barrel = 0, NegEndcap = 1, PosEndcap = 2 }; | ||
}; | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
RecoPixelVertexing/PixelTriplets/plugins/PixelQuadrupletGenerator.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is anything else expected inside
struct TrackerDetSide
?this could be
enum class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I had a reason for using unscoped
enum
, but I see in the end there is only one place converting it to/from a number and that is already usingstatic_cast
. Will change toenum class
(after you complete the review).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were more conversions from the enum to an unsigned int in
HitExtractor*
. Something that could be also considered is to propagate this enum toTrackerTopology
(as the numbering is intentionally consistent withTrackerTopology::side()
(but that is beyond this PR).