Utilities/StaticAnalyzers: update #21150
Conversation
ConstCastAway, ConstCast and MutableMember checks moved to new catagory ConstThreadSafety and the filter isDataClass removed. This will allow the global producer check to work when any of these problem appear in the class.
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21150/1795 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21150/1795/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: Utilities/StaticAnalyzers @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 5f47be8 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: ClangBuild
I found a compilation error while trying to compile with clang: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/ThrUnsafeFCallChecker.cpp
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/CmsSupport.cpp
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/CatchAll.cpp
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/GlobalStaticChecker.cpp
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp:25:15: error: unused variable 'SE' [-Werror,-Wunused-variable]
const Expr * SE = CE->getSubExpr();
^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2017-11-03-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:22:15: error: unused variable 'SE' [-Werror,-Wunused-variable]
const Expr * SE = CE->getSubExprAsWritten();
^
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #21150 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
hi @Dr15Jones - what is the status of this PR? |
|
@gartung did you finish all the changes you wanted to do? |
|
yes |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
ConstCastAway, ConstCast and MutableMember checks moved to new catagory ConstThreadSafety and the filter isDataClass removed. This will allow the global producer check to work when any of these problem appear in the class.