Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks 93X - backport ability to set event center #21163

Merged
merged 4 commits into from Nov 23, 2017

Conversation

alja
Copy link
Contributor

@alja alja commented Nov 3, 2017

This is backport of #20633.

@alja
Copy link
Contributor Author

alja commented Nov 3, 2017

+1

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Nov 3, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24175/console Started: 2017/11/03 21:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_9_3_X.

It involves the following packages:

Fireworks/Calo
Fireworks/Core
Fireworks/Geometry
Fireworks/Vertices

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor Author

alja commented Nov 16, 2017

-code-checks

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0a096db into cms-sw:CMSSW_9_3_X Nov 23, 2017
@alja alja deleted the shiftOrigin-backport-93x branch April 8, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants