-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Phase 1 Pixel Premixing #21175
Fix Phase 1 Pixel Premixing #21175
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mdhildreth for master. It involves the following packages: SimGeneral/DataMixingModule @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
IIUC, this fix is a follow up to #20555 |
no way for a 10 event test to catch such a small problem... (especially when the gensim->premixed library step is not redone. But no objections to adding a premixed job to the short matrix (can you suggest something that is obsolete and can be removed?) |
+1 |
On 11/6/17 9:35 AM, David Lange wrote:
no way for a 10 event test to catch such a small problem... (especially
when the gensim->premixed library step is not redone. But no objections
to adding a premixed job to the short matrix (can you suggest something
that is obsolete and can be removed?)
I think that these could be dropped
1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/
1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21175 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbhAyZtAjY-mE3KlMMafLxzLVGJk5ks5szsTBgaJpZM4QSgn3>.
|
Remove practice of putting dead pixel digis in with zero ADC counts. Apparently the clustering filter in the Pixels no longer ignores them.