Fix Phase 1 Pixel Premixing

[mdhildreth]

Remove practice of putting dead pixel digis in with zero ADC counts. Apparently the clustering filter in the Pixels no longer ignores them.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mdhildreth]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21175/1832

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24194/console Started: 2017/11/05 21:09

[cmsbuild]

A new Pull Request was created by @mdhildreth for master.

It involves the following packages:

SimGeneral/DataMixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 8a4b7c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21175/24194/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9b8d11d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21175/24194/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21175/24194/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21175/24194/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2900266
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2900094
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

IIUC, this fix is a follow up to #20555
Perhaps the issue could be resolved faster with a premixing workflow tested in jenkins short workflow.
@davidlange6 @fabozzi

[davidlange6]

no way for a 10 event test to catch such a small problem... (especially when the gensim->premixed library step is not redone. But no objections to adding a premixed job to the short matrix (can you suggest something that is obsolete and can be removed?)

[davidlange6]

+1

[slava77]

On 11/6/17 9:35 AM, David Lange wrote: no way for a 10 event test to catch such a small problem... (especially when the gensim->premixed library step is not redone. But no objections to adding a premixed job to the short matrix (can you suggest something that is obsolete and can be removed?)

I think that these could be dropped 1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/ 1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbhAyZtAjY-mE3KlMMafLxzLVGJk5ks5szsTBgaJpZM4QSgn3>.