Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1T offine DQM changes for pp reference run #21188

Merged
merged 9 commits into from Nov 8, 2017
Merged

L1T offine DQM changes for pp reference run #21188

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1901fab
add "Run2_2017_ppRef" era to run customized reco for pp reference and…
Nov 1, 2017
82e0e53
Add toModify for Run2_2017_ppRef era.
thomreis Nov 6, 2017
5cdff90
Remove eventually prescaled path with 7 GeV threshold.
thomreis Nov 6, 2017
3687e18
Move muon offline dqm configuration modifications to cff file.
thomreis Nov 6, 2017
c38e0f0
Fix typo.
thomreis Nov 6, 2017
77a4fe7
Import thresholds from the cff.
thomreis Nov 6, 2017
243a2bd
Merge branch 'master' into l1t_offline_dqm_changes_for_ppref_run
thomreis Nov 7, 2017
cf1894b
Move modifier back to the cfi.
thomreis Nov 8, 2017
bd00ad1
Import cfi instead of cff.
thomreis Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 22 additions & 1 deletion DQMOffline/L1Trigger/python/L1TMuonDQMEfficiency_cff.py
View file
Open in desktop
@@ -1,6 +1,6 @@
import FWCore.ParameterSet.Config as cms

from DQMOffline.L1Trigger.L1TMuonDQMOffline_cfi import muonEfficiencyThresholds
from DQMOffline.L1Trigger.L1TMuonDQMOffline_cff import muonEfficiencyThresholds, muonEfficiencyThresholds_HI

plots = ["EffvsPt", "EffvsEta", "EffvsPhi",
"EffvsPt_OPEN", "EffvsEta_OPEN", "EffvsPhi_OPEN",
Expand All @@ -13,6 +13,12 @@
plotName = '{0}_{1}'.format(plot, threshold)
allEfficiencyPlots.append(plotName)

allEfficiencyPlots_HI = []
for plot in plots:
for threshold in muonEfficiencyThresholds_HI:
plotName = '{0}_{1}'.format(plot, threshold)
allEfficiencyPlots_HI.append(plotName)

from DQMOffline.L1Trigger.L1TEfficiencyHarvesting_cfi import l1tEfficiencyHarvesting
l1tMuonDQMEfficiency = l1tEfficiencyHarvesting.clone(
plotCfgs = cms.untracked.VPSet(
Expand All @@ -25,3 +31,18 @@
)
)
)

# modifications for the pp reference run
from Configuration.Eras.Modifier_ppRef_2017_cff import ppRef_2017
ppRef_2017.toModify(l1tMuonDQMEfficiency,
plotCfgs = cms.untracked.VPSet(
cms.untracked.PSet(
numeratorDir = cms.untracked.string("L1T/L1TMuon/numerators_and_denominators"),
outputDir = cms.untracked.string("L1T/L1TMuon"),
numeratorSuffix = cms.untracked.string("_Num"),
denominatorSuffix = cms.untracked.string("_Den"),
plots = cms.untracked.vstring(allEfficiencyPlots_HI)
)
)
)

15 changes: 15 additions & 0 deletions DQMOffline/L1Trigger/python/L1TMuonDQMOffline_cff.py
View file
Open in desktop
@@ -0,0 +1,15 @@
import FWCore.ParameterSet.Config as cms

from DQMOffline.L1Trigger.L1TMuonDQMOffline_cfi import *

# modifications for the pp reference run
muonEfficiencyThresholds_HI = [5, 7, 12]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @thomreis - please move these lines into the file that defines l1tMuonDQMOffline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[from line 5 to 14]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that before and thought it should not be in a cfi. I will move it back.

from Configuration.Eras.Modifier_ppRef_2017_cff import ppRef_2017
ppRef_2017.toModify(l1tMuonDQMOffline,
gmtPtCuts = cms.untracked.vint32(muonEfficiencyThresholds_HI),
tagPtCut = cms.untracked.double(14.),
triggerNames = cms.untracked.vstring(
"HLT_HIL3Mu12_v*",
)
)

4 changes: 2 additions & 2 deletions DQMOffline/L1Trigger/python/L1TriggerDqmOffline_cff.py
View file
Open in desktop
Expand Up @@ -273,8 +273,8 @@
l1tEGammaOfflineDQMEmu.stage2CaloLayer2EGammaSource=cms.InputTag("valCaloStage2Layer2Digis")

from DQMOffline.L1Trigger.L1TTauOffline_cfi import *
l1tTauOfflineDQMEmu.stage2CaloLayer2TaySource=cms.InputTag("valCaloStage2Layer2Digis")
from DQMOffline.L1Trigger.L1TMuonDQMOffline_cfi import *
l1tTauOfflineDQMEmu.stage2CaloLayer2TauSource=cms.InputTag("valCaloStage2Layer2Digis")
from DQMOffline.L1Trigger.L1TMuonDQMOffline_cff import *

from DQM.L1TMonitor.L1TStage2_cff import *
from DQMOffline.L1Trigger.L1TriggerDqmOffline_SecondStep_cff import *
Expand Down