Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecated Cond DB Configuration #21198

Merged
merged 1 commit into from Nov 8, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Nov 7, 2017

Replace deprecated CondCore.DBCommon.CondDBSetup_cfi with CondCore.CondDB.CondDB_cfi

@ianna
Copy link
Contributor Author

ianna commented Nov 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21198/1851

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24230/console Started: 2017/11/07 11:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/CSCGeometry
Geometry/CaloEventSetup
Geometry/DTGeometry
Geometry/TrackerGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @VinInn, @ptcox, @ebrondol, @venturia this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Nov 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21198/24230/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2755261
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2755091
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e5cfcbc into cms-sw:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants