Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L1TMuonEndCap warning regarding Phase 2 iRPC hits #21203

Merged
merged 1 commit into from Nov 15, 2017

Conversation

jiafulow
Copy link
Contributor

@jiafulow jiafulow commented Nov 7, 2017

This PR should fix #21201 reported by @kpedro88 .

The current L1 EMTF emulator is not designed to handle Phase 2 iRPC hits (RPC hits from RE3/1 and RE4/1). Using the hits will likely produce code crashes or simply bogus results. This PR simply removes the hits from entering the EMTF emulator. This is a temporary solution.

Further discussion can be found on the issue above (#21201).

@abrinke1 , @kpedro88 please check/comment, thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21203/1856

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

A new Pull Request was created by @jiafulow (Jia Fu Low) for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24253/console Started: 2017/11/07 22:12

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21203/24253/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2903670
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2903498
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 9, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 9, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 56d188b into cms-sw:master Nov 15, 2017
@jiafulow jiafulow deleted the patch-2 branch March 19, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

silence or fix Muon L1T warnings/errors
4 participants