New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix L1TMuonEndCap warning regarding Phase 2 iRPC hits #21203
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @jiafulow (Jia Fu Low) for master. It involves the following packages: L1Trigger/L1TMuonEndCap @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
assign upgrade |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 |
merge |
This PR should fix #21201 reported by @kpedro88 .
The current L1 EMTF emulator is not designed to handle Phase 2 iRPC hits (RPC hits from RE3/1 and RE4/1). Using the hits will likely produce code crashes or simply bogus results. This PR simply removes the hits from entering the EMTF emulator. This is a temporary solution.
Further discussion can be found on the issue above (#21201).
@abrinke1 , @kpedro88 please check/comment, thanks!