New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition to Join Opt Meeting 2017.10.20 action item : rollback HLTDQM #21231
Conversation
…lots in the workflows run for the validation (as requested at the Join Opt Meeting 2017.10.20)
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Configuration/PyReleaseValidation @prebello, @vazzolini, @dmitrijus, @kmaeshima, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @jfernan2, @GurpreetSinghChahal, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
hi @mtosi - this broke one workflow could you have a look? |
I'm pretty sure this pull request broke the IB RelVal workflow 136.7802. See The problem boiled down to
The file containing B2GegHLTDQMOfflineTnPSource was modified by this pull request. |
Yes - I reported it above to @mtosi
… On Nov 10, 2017, at 7:50 PM, Chris Jones ***@***.***> wrote:
I'm pretty sure this pull request broke the IB RelVal workflow 136.7802. See
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc630/CMSSW_10_0_X_2017-11-09-2300/pyRelValMatrixLogs/run/136.7802_RunHLTPhy2017B_AODextra+RunHLTPhy2017B_AODextra+DQMHLTonAODextra_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_AODextra+RunHLTPhy2017B_AODextra+DQMHLTonAODextra_2017+HARVESTDQMHLTonAOD_2017.log
The problem boiled down to
An exception of category 'ScheduleExecutionFailure' occurred while
[0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found:
egmGsfElectronIDsForDQM after VBFSUSYmonitoring [path dqmoffline_step],
...{all the other modules on path dqmoffline_step}...
SinglePhoton300_monitoring after B2GegHLTDQMOfflineTnPSource [path dqmoffline_step],
B2GegHLTDQMOfflineTnPSource consumes egmGsfElectronIDsForDQM
Running in the threaded framework would lead to indeterminate results.
Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------
The file containing B2GegHLTDQMOfflineTnPSource was modified by this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I think we should (in addition) move DQM modules from EndPath to Path as much as possible (also for many other reasons than creating so easily unrunnable schedule). |
@makortel I've been thinking about adding another path type such as |
Yes, I agree - the dqm seems not to support this philosophy unfortunately...
… On Nov 10, 2017, at 9:08 PM, Matti Kortelainen ***@***.***> wrote:
I think we should (in addition) move DQM modules from EndPath to Path as much as possible (also for many other reasons than creating so easily unrunnable schedule).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Yes, YES! @Dr15Jones Would it be possible to have a chat with you, let's say, tomorrow, skype/vidyo/real life?
I personally support that fully. |
Arrange changes in #20980 so that the extra hlt histograms can be enabled also in workflows not running the "standard dqm"