Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cpu waster from premixing workflow #21234

Merged
merged 2 commits into from Nov 9, 2017
Merged

remove cpu waster from premixing workflow #21234

merged 2 commits into from Nov 9, 2017

Conversation

davidlange6
Copy link
Contributor

No description provided.

Dr15Jones and others added 2 commits November 9, 2017 13:34
@Dr15Jones @davidlange6
Properly handle arrays where index can be negative
3a68239 
Instead of relying on remembering to always adding an offset to the
index being passed to the array, we now use a helper class which
always does the offsetting for us. The helper also properly initializes
the size of the array to be able to contain the min and max bounds.
@davidlange6
remove cpu waster
0567d83
@davidlange6
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Nov 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24307/console Started: 2017/11/09 14:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_9_4_X.

It involves the following packages:

Configuration/StandardSequences
L1Trigger/L1TTwinMux

@cmsbuild, @rekovic, @franzoni, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

+1
Tested at: 0567d83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21234/24307/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3e73eef
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21234/24307/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21234/24307/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21234/24307/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2914206
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2913935
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit f7d493c into cms-sw:CMSSW_9_4_X Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending operations-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlange6 @cmsbuild @Dr15Jones