Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T offine DQM changes for pp reference run - part1+2 - 94x #21236

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Nov 9, 2017

Backport of #21228

To make the L1T offline DQM work for the pp reference run the trigger paths used must be adapted for the pp reference run HLT menu.

Part 2: L1T EG and L1T Jets

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_4_X.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Nov 9, 2017

Merged in PR #21197 to avoid conflicts.
This PR can now handle the backports of #21188 (merged already) and #21228 .

@thomreis thomreis changed the title L1T offine DQM changes for pp reference run - part2 - 94x L1T offine DQM changes for pp reference run - part1+2 - 94x Nov 9, 2017
@rekovic
Copy link
Contributor

rekovic commented Nov 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24317/console Started: 2017/11/09 16:25

@rekovic
Copy link
Contributor

rekovic commented Nov 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21236/24317/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2914206
  • DQMHistoTests: Total failures: 101
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2913933
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@thomreis thomreis closed this Jan 29, 2018
@thomreis thomreis deleted the l1t_offline_dqm_changes_for_ppref_run_part2_94x branch September 20, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants