[10.0.x] Update of SiStrip PI classes #21265

mmusich · 2017-11-10T16:10:03Z

Features added:

Implement different levels of saturation for the TrackerMaps via class templates;
Add plot of integral gain distribution comparison;
Add 2D plots of gain ratios;
Correct nomenclature; rename everywhere "partition" to more appropriate "region";

Bug-fixes:

Fixed buggy logic in filling the TrackerMap of the maximum deviation of the ratio;
Fixed off-by-one bin filling in SiStripApvAbsolute* plots;

…ratio plot and rename partition to region

cmsbuild · 2017-11-10T16:10:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-10T16:12:57Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21265/1933

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21265/1933/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-21265/1933/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2017-11-10T16:19:44Z

The code-checks are being triggered in jenkins.

mmusich · 2017-11-10T16:19:48Z

type bug-fix

cmsbuild · 2017-11-10T16:22:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21265/1936

cmsbuild · 2017-11-10T16:26:38Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

davidlange6 · 2017-11-10T17:42:50Z

please test

cmsbuild · 2017-11-10T17:43:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24361/console Started: 2017/11/10 19:38

cmsbuild · 2017-11-10T20:41:38Z

+1
Tested at: 5339e6e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21265/24361/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
62cb420
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21265/24361/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21265/24361/git-merge-result

cmsbuild · 2017-11-10T20:41:41Z

Comparison job queued.

cmsbuild · 2017-11-10T22:21:56Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21265/24361/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2832699
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2832520
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.89000000005 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

ggovi · 2017-11-14T09:11:42Z

+1

cmsbuild · 2017-11-14T09:11:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2017-11-20T09:11:44Z

Hello,
is there any problem with integrating this PR?
Thanks,

davidlange6 · 2017-11-20T10:43:22Z

CondCore/SiStripPlugins/interface/SiStripPayloadInspectorHelper.h

-    case SiStripPI::TID3s: return "TID D3 stereo";
-    case SiStripPI::END_OF_REGIONS : return "undefined";
-    default : return "should never be here";  
+    case SiStripPI::TIB1r: return std::make_pair(1 ,"TIB L1 r-#varphi");


hi @mmusich - sorry for the delay - how do you plan to use this new index ? (I don't think its used below). The enum has an index already

HI @davidlange6, I need it to get the bin number to fill in e.g. https://github.com/cms-sw/cmssw/pull/21265/files#diff-0eaa5baaa2c31b79f1f2bbf7573a8eb3R1454.
I cannot use the indexing already associated to the enum because that one is used to couple it to internal indexing used in SiStripDetSummary

cmssw/CondFormats/SiStripObjects/interface/SiStripDetSummary.h

Line 46 in ee01ed6

if( layer <= stereo[subDet] ) valueMap_[1000*(subDet+1)+layer*10+1] = initValues;

davidlange6 · 2017-11-20T11:07:04Z

ah - thanks

…

On Nov 20, 2017, at 11:52 AM, Marco Musich ***@***.***> wrote: @mmusich commented on this pull request. In CondCore/SiStripPlugins/interface/SiStripPayloadInspectorHelper.h: > - case SiStripPI::TEC6s: return "TEC D6 stereo"; - case SiStripPI::TEC7r: return "TEC D7 r-#varphi"; - case SiStripPI::TEC7s: return "TEC D7 stereo"; - case SiStripPI::TEC8r: return "TEC D8 r-#varphi"; - case SiStripPI::TEC8s: return "TEC D8 stereo"; - case SiStripPI::TEC9r: return "TEC D9 r-#varphi"; - case SiStripPI::TEC9s: return "TEC D9 stereo"; - case SiStripPI::TID1r: return "TID D1 r-#varphi"; - case SiStripPI::TID1s: return "TID D1 stereo"; - case SiStripPI::TID2r: return "TID D2 r-#varphi"; - case SiStripPI::TID2s: return "TID D2 stereo"; - case SiStripPI::TID3r: return "TID D3 r-#varphi"; - case SiStripPI::TID3s: return "TID D3 stereo"; - case SiStripPI::END_OF_REGIONS : return "undefined"; - default : return "should never be here"; + case SiStripPI::TIB1r: return std::make_pair(1 ,"TIB L1 r-#varphi"); HI @davidlange6, I need it to get the bin number to fill in e.g. https://github.com/cms-sw/cmssw/pull/21265/files#diff-0eaa5baaa2c31b79f1f2bbf7573a8eb3R1454. I cannot use the indexing already associated to the enum because that one is used to couple it to internal indexing used in SiStripDetSummary https://github.com/cms-sw/cmssw/blob/ee01ed60f0498e0ee4e4ce2fd3f70efe474c96b1/CondFormats/SiStripObjects/interface/SiStripDetSummary.h#L46 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

davidlange6 · 2017-11-20T11:07:09Z

merge

…

On Nov 20, 2017, at 11:52 AM, Marco Musich ***@***.***> wrote: @mmusich commented on this pull request. In CondCore/SiStripPlugins/interface/SiStripPayloadInspectorHelper.h: > - case SiStripPI::TEC6s: return "TEC D6 stereo"; - case SiStripPI::TEC7r: return "TEC D7 r-#varphi"; - case SiStripPI::TEC7s: return "TEC D7 stereo"; - case SiStripPI::TEC8r: return "TEC D8 r-#varphi"; - case SiStripPI::TEC8s: return "TEC D8 stereo"; - case SiStripPI::TEC9r: return "TEC D9 r-#varphi"; - case SiStripPI::TEC9s: return "TEC D9 stereo"; - case SiStripPI::TID1r: return "TID D1 r-#varphi"; - case SiStripPI::TID1s: return "TID D1 stereo"; - case SiStripPI::TID2r: return "TID D2 r-#varphi"; - case SiStripPI::TID2s: return "TID D2 stereo"; - case SiStripPI::TID3r: return "TID D3 r-#varphi"; - case SiStripPI::TID3s: return "TID D3 stereo"; - case SiStripPI::END_OF_REGIONS : return "undefined"; - default : return "should never be here"; + case SiStripPI::TIB1r: return std::make_pair(1 ,"TIB L1 r-#varphi"); HI @davidlange6, I need it to get the bin number to fill in e.g. https://github.com/cms-sw/cmssw/pull/21265/files#diff-0eaa5baaa2c31b79f1f2bbf7573a8eb3R1454. I cannot use the indexing already associated to the enum because that one is used to couple it to internal indexing used in SiStripDetSummary https://github.com/cms-sw/cmssw/blob/ee01ed60f0498e0ee4e4ce2fd3f70efe474c96b1/CondFormats/SiStripObjects/interface/SiStripDetSummary.h#L46 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mmusich added 6 commits November 2, 2017 18:24

Add ratio and comparison of gains per partition

b4f0e32

Add Comparison of gain values

dfc9e77

Implement saturation template for tracker map, fix the max deviation …

ed8770b

…ratio plot and rename partition to region

improve on the SiStripPI::regionType() interface

18cac2d

few graphical fixes

d9a3c60

adjust saturation scale in the avg gain plot

e1a8d51

cmsbuild added this to the CMSSW_10_0_X milestone Nov 10, 2017

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Nov 10, 2017

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 10, 2017

apply code-checks

5339e6e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 10, 2017

cmsbuild added the bug-fix label Nov 10, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 10, 2017

cmsbuild removed the tests-pending label Nov 10, 2017

cmsbuild added the tests-started label Nov 10, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Nov 14, 2017

davidlange6 reviewed Nov 20, 2017

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Nov 20, 2017

cmsbuild merged commit 8ecebe6 into cms-sw:master Nov 20, 2017

mmusich mentioned this pull request Nov 20, 2017

Migrate Fireworks from tracker-sub-DetId to TrackerTopology #21298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0.x] Update of SiStrip PI classes #21265

[10.0.x] Update of SiStrip PI classes #21265

mmusich commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

mmusich commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

davidlange6 commented Nov 10, 2017

cmsbuild commented Nov 10, 2017 •

edited

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

ggovi commented Nov 14, 2017

cmsbuild commented Nov 14, 2017

mmusich commented Nov 20, 2017

davidlange6 Nov 20, 2017

mmusich Nov 20, 2017

davidlange6 commented Nov 20, 2017 via email

davidlange6 commented Nov 20, 2017 via email

[10.0.x] Update of SiStrip PI classes #21265

[10.0.x] Update of SiStrip PI classes #21265

Conversation

mmusich commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

mmusich commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

davidlange6 commented Nov 10, 2017

cmsbuild commented Nov 10, 2017 • edited

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

ggovi commented Nov 14, 2017

cmsbuild commented Nov 14, 2017

mmusich commented Nov 20, 2017

davidlange6 Nov 20, 2017

Choose a reason for hiding this comment

mmusich Nov 20, 2017

Choose a reason for hiding this comment

davidlange6 commented Nov 20, 2017 via email

davidlange6 commented Nov 20, 2017 via email

cmsbuild commented Nov 10, 2017 •

edited