Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modes to ignore the original masks and prescales #21273

Merged
merged 1 commit into from Nov 14, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 10, 2017

Add two new modes:

  • "ForcePrescaleValues" to apply the given prescale values
  • "ForceColumnValues" to apply the prescales from the given column
    ignoring the prescales and masks already applied.

Useful for example when skimming ZeroBias events, to ignore the masks and prescales used durign data taking.

Add two new modes:
  - "ForcePrescaleValues" to apply the given prescale values
  - "ForceColumnValues"   to apply the prescales from the given column
ignoring the prescales and masks already applied.

Useful for example when skimming ZeroBias events, to ignore the masks
and prescales used durign data taking.
@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 10, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21273/1949

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24370/console Started: 2017/11/10 21:15

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21273/24370/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2832699
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2832520
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.03999999997 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Nov 14, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9909322 into cms-sw:master Nov 14, 2017
@fwyzard fwyzard deleted the L1TGlobalPrescaler_force_prescales branch November 23, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants