Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accidentally committed changes in CalibTracker/SiStripDCS [94X] #21303

Conversation

pieterdavid
Copy link
Contributor

Backport of #21302 for CMSSW_9_4_X.
This reverts commit 5845237, which was not needed and broke the SiStrip DCS O2O in CMSSW_9_4_0.

CC: @hqucms @boudoul

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pieterdavid (Pieter David) for CMSSW_9_4_X.

It involves the following packages:

CalibTracker/SiStripDCS

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @jlagram, @mmusich, @gbenelli, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Nov 15, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24456/console Started: 2017/11/15 17:09

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21303/24456/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2779661
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779384
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Nov 20, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7c5eda0 into cms-sw:CMSSW_9_4_X Nov 21, 2017
@pieterdavid pieterdavid deleted the revert-sistripdetvoffbuilderhandlerchange-stripdcso2o_94X branch September 28, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants