Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10X] L1T Validation Module with with GeneratorParticle Information: put denom/nominator hists into a sub-dir #21323

Merged
merged 1 commit into from Dec 1, 2017

Conversation

ly615
Copy link
Contributor

@ly615 ly615 commented Nov 15, 2017

This PR makes two updates in Validation/L1T package which is used to fill the L1TriggerVsGen histograms for L1T RelVal:

  1. put denominator/nominator hists into a sub-dir
  2. setEfficiencyFlag for efficiency plots
    The PR has been tested with "runTheMatrix.py --what upgrade -l 10024.0 -i all", no problem shows up.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21323/2006

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ly615 (Li Yuan) for master.

It involves the following packages:

Validation/L1T

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24453/console Started: 2017/11/15 16:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21323/24453/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2832540
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2832361
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.83999999999 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@thomreis
Copy link
Contributor

Hi @dmitrijus @jfernan2
please have a look at this PR and let us know if it looks OK for you. There is also a backport PR related to it that need to be tested.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 327ba3e into cms-sw:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants