Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EventGenerationFailure exit code #21330

Merged
merged 2 commits into from Nov 21, 2017

Conversation

perrozzi
Copy link
Contributor

to catch missing or exceeding LHE events

@perrozzi
Copy link
Contributor Author

backport of #21328

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2017

A new Pull Request was created by @perrozzi for CMSSW_7_1_X.

It involves the following packages:

FWCore/Utilities
GeneratorInterface/LHEInterface

@smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi, @thuer, @cmsbuild, @govoni can you please review it and eventually sign? Thanks.
@mkirsano, @makortel, @felicepantaleo, @wddgit, @Martin-Grunewald, @agrohsje, @alberto-sanchez, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrozzi
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24485/console Started: 2017/11/16 22:58

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Tested at: 02bdc42

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bd6cf02
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21330/24485/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21330/24485/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21330/24485/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testCoralSQLPrinting had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bd6cf02
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21330/24485/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21330/24485/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21330/24485/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 736311
  • DQMHistoTests: Total failures: 3410
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 732480
  • DQMHistoTests: Total skipped: 421
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 46 log files, 4 edm output root files, 12 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 421986b into cms-sw:CMSSW_7_1_X Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants