Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T online and offline DQM configuration upgrades - 94x #21340

Closed

Conversation

thomreis
Copy link
Contributor

backport of #21334

L1T online and offline DQM improvements.

  • Move the TF emulators and the uGT emulator before the fat event filter to have better statistics for the comparisons. This means the modules are then also ran in the offline DQM.
  • Ignore BX range mismatches for BMTF and EMTF data to emulator comparison in the summary.
  • Remove the old unpacker for CaloLayer1 and use the rawToDigi standard sequence instead.
  • Remove unneeded unpackers from the online DQM clients.
  • Add the ESProducer for the ideal magnetic field to the online client because it is needed by the EMTF emulator.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_4_X.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient
DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@makortel, @rociovilar, @threus, @kreczko, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24491/console Started: 2017/11/17 00:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21340/24491/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2779661
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779384
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Nov 17, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@thomreis thomreis closed this Jan 29, 2018
@thomreis thomreis deleted the l1temu_dqm_online_to_offline_94x branch September 20, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants