Reduce LogWarning for non-existing tau discriminators during pat::Tau candidate creation

[roger-wolf]

The change is purely technical and minimal as can be seen from the commits. It follows an issue raised by Slava (*).

Cheers,
Roger

(*)
https://github.com/cms-sw/cmssw/pull/21022/files#diff-c7c5c83df6323f1a53a05655cd079d3fR319

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21348/2042

[cmsbuild]

A new Pull Request was created by @roger-wolf (Roger Wolf) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24500/console Started: 2017/11/17 12:37

[cmsbuild]

+1
Tested at: 01b008a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21348/24500/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4a2a37d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21348/24500/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21348/24500/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21348/24500/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.21999999999 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[perrotta]

Output of the PhysicsTools/PatAlgos unit tests improves from

Begin processing the 1st record. Run 1, Event 2, LumiSection 1 at 20-Nov-2017 12:34:49.000 CET
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:34:59 CET  Run: 1 Event: 2
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
Begin processing the 2nd record. Run 1, Event 1, LumiSection 1 at 20-Nov-2017 12:35:01.206 CET
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:35:01 CET  Run: 1 Event: 1
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:35:01 CET  Run: 1 Event: 1
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:35:01 CET  Run: 1 Event: 1
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:35:01 CET  Run: 1 Event: 1
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
%MSG-w DataSource:  PATTauProducer:patTaus 20-Nov-2017 12:35:01 CET  Run: 1 Event: 1
Tau discriminator 'byVVLooseIsolationMVArun2v1DBoldDMwLT' has not been found in the event. It will not be embedded into the pat::Tau object.
%MSG
Begin processing the 3rd record. Run 1, Event 3, LumiSection 1 at 20-Nov-2017 12:35:01.259 CET
...

to

Begin processing the 1st record. Run 1, Event 2, LumiSection 1 at 17-Nov-2017 13:52:05.610 CET
%MSG-w DataSource:  PATTauProducer:patTaus 17-Nov-2017 13:52:07 CET  Run: 1 Event: 2
The following tau discriminators have not been found in the event:
byVVLooseIsolationMVArun2v1DBoldDMwLT
They will not be embedded into the pat::Tau object.
Note: this message will be printed only at first occurence.
%MSG
Begin processing the 2nd record. Run 1, Event 1, LumiSection 1 at 17-Nov-2017 13:52:16.029 CET
Begin processing the 3rd record. Run 1, Event 3, LumiSection 1 at 17-Nov-2017 13:52:16.064 CET
...

[perrotta]

+1

• The cleaning of the logs as in Reduce LogWarning for non-existing tau discriminators during pat::Tau candidate creation #21348 (comment) corresponds to what asked for in reduce verbosity of skipMissingTauID #21346
• Differences in jenkis tests point to the log error harvester, not relates to this PR

[davidlange6]

merge