Code added to Produce SiStrip trends of number of channel errors per …

[Wilsker]

…fed id per LS

Plots added to SiStripMonitorHardware FEDHistograms package and filled in SiStripFEDMonitor.cc. Plot is TProfile2D so added classes to HistogramBase to get and fill such histrograms. Added argument to FEDErrors fillBadChannelList method to count channel errors per fed id (previously only cumulative numbers available).

Modified packages beneath.
modified: DQM/SiStripMonitorHardware/interface/FEDErrors.hh
modified: DQM/SiStripMonitorHardware/interface/FEDHistograms.hh
modified: DQM/SiStripMonitorHardware/interface/HistogramBase.hh
modified: DQM/SiStripMonitorHardware/python/siStripFEDMonitor_cfi.py
modified: DQM/SiStripMonitorHardware/src/FEDErrors.cc
modified: DQM/SiStripMonitorHardware/src/FEDHistograms.cc
modified: DQM/SiStripMonitorHardware/src/HistogramBase.cc
modified: DQM/SiStripMonitorHardware/src/SiStripFEDMonitor.cc

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21355/2050

[cmsbuild]

A new Pull Request was created by @Wilsker for master.

It involves the following packages:

DQM/SiStripMonitorHardware

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24510/console Started: 2017/11/17 19:49

[cmsbuild]

+1
Tested at: 6e8aac7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21355/24510/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4a2a37d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21355/24510/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21355/24510/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21355/24510/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• You potentially added 367316 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2675252
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2675075
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.649999999994 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[dmitrijus]

+1

[Wilsker]

@dmitrijus Thanks a lot for that. I removed the offending lines and committed the edit.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21355/2695

[cmsbuild]

Pull request #21355 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[dmitrijus]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25574/console Started: 2018/01/23 14:01

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 50f99c4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21355/25574/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21355/25574/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21355/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2467599
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2467429
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.1499999999 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[fabiocos]

+1