Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch fed error trend online client #21656

Merged
merged 2 commits into from Dec 13, 2017

Conversation

Wilsker
Copy link
Contributor

@Wilsker Wilsker commented Dec 7, 2017

…of channel errors per FED ID. Removed modules from 'process.InitialStepPreSplittingTask' so online client doesnt crash due to trying to override definition of siPixelClusters while it is used by the task InitialStepPreSplittingTask. Added global switch to online clients to enable trend plots of channel errors per FED ID.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2017

The code-checks are being triggered in jenkins.

@Wilsker
Copy link
Contributor Author

Wilsker commented Dec 7, 2017

Reference PR for enabled distributions:

#21355

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21656/2484

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2017

A new Pull Request was created by @Wilsker for master.

It involves the following packages:

DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25054/console Started: 2017/12/12 17:31

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21656/25054/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21656/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835241
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2835062
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.11000000003 KiB( 23 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 8a28371 into cms-sw:master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants