Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second NanoAOD update (94X version) - includes first NanoAOD update not yet merged #21399

Merged
merged 139 commits into from Nov 28, 2017
Merged

Second NanoAOD update (94X version) - includes first NanoAOD update not yet merged #21399

merged 139 commits into from Nov 28, 2017

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Nov 21, 2017

Same as #21376 (different base)
Includes #21300 (merged only in its master variant at the moment, #21095)

This PR contains:

  • update of Gen information (dressed leptons, gen jet flavour etc..)
  • fix bug Uint8 -> bool
  • muon ID from muon POG object functions
  • updated list of btag discriminators
  • review of substructures information
  • protect against non-thread safeness of StringParser
  • update electron variables
  • fix of L1 seed pt
  • update of tau trig object
  • addition of LHE NLO info

@gpetruc @peruzzim

mseidel42 and others added 30 commits September 26, 2017 11:31
@mseidel42
Merged nano_94X from repository cms-nanoAOD with cms-merge-topic
b57fc90
@mseidel42
Objects from Rivet-based ParticleLevelProducer
3e00f78
@gouskos
add met unclustered uncertainty
a7d14c6
@gpetruc
Merge tag 'CMSSW_9_4_0_pre2'
cb9f8be
@mseidel42
Merged RivetJets with GenJets (no lepton cleaning), removed RivetTags…
53945aa 
…, renamed RivetFatJets/DressedLeptons->GenFatJets/DressedLeptons
@gpetruc
Add pointing angle
352997a
@gpetruc
Merge branch 'nano_94X' of github.com:cms-nanoAOD/cmssw
e3a763a
@fgolf
first implementation of isolated tracks for nanoAOD
4639b6a
@fgolf
remove high purity requirement
5837ea0
@fgolf
change tabs to spaces; change int to bool where appropriate
8319f9c
@gpetruc
improved size & doc report
7c35d56
@olaiya
Added non-PF track, ecal and hcal isolation within a cone of 0.3
0bd3bb5
@gpetruc
set executable bit
bb9a53a
@gpetruc
Merge pull request #37 from gpetruc/better_size_and_doc_report
aa121ec 
improved size & doc report
@arizzi
Merge pull request #40 from arizzi/nano_94X_wTests
bcf76ce 
add integration tests
@olaiya
For electrons with pt > 35.0 GeV store non-PF track, ecal and hcal is…
66c6391 
…olation within a cone of 0.3
@gpetruc
Merge pull request #38 from olaiya/cms-nanoAOD/master_moreElectronVars
ce615a5 
Added non-PF track, ecal and hcal isolation within a cone of 0.3
@gpetruc
Merge pull request #32 from fgolf/forNanoAOD_isoTracks
e45aa9c 
For nano aod iso tracks
@gouskos
Update met_cff.py
28b98c7
@gpetruc
Merge pull request #31 from gouskos/cms-nanoAOD/nano_94X
feba362 
add met unclustered uncertainty
@gpetruc
Merge branch 'nano_94X' of github.com:cms-nanoAOD/cmssw into merge_94X
e854212
@gpetruc
Merge remote-tracking branch 'my-cmssw/Comp2RefEqualH_for_TProfile' i…
7466494 
…nto new_dqm
@gpetruc
support for merging flat tables
48a003a
@gpetruc
DQM (to be continued)
35be574
@gpetruc
Support for getting any value from FlatTable given row & column
945ca51
@gpetruc
Change configuration syntax, support profile plots
ba280e4
@gpetruc
FlatTable::RowView (transient-only, for DQM)
ed9165d
@gpetruc
more DQM stuff
8172f72
@gpetruc
improve DQM
fc3a72e
@gpetruc
Get DQM running on top of current master branch
30fa9d1
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_9_4_X.

It involves the following packages:

Configuration/PyReleaseValidation
DQMOffline/Configuration
DataFormats/NanoAOD
PhysicsTools/NanoAOD
PhysicsTools/PatAlgos

@perrotta, @prebello, @monttj, @vazzolini, @kmaeshima, @kpedro88, @fabozzi, @cmsbuild, @jfernan2, @slava77, @GurpreetSinghChahal, @vanbesien, @dmitrijus can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @gouskos, @felicepantaleo, @rappoccio, @Martin-Grunewald, @ahinzmann, @threus, @seemasharmafnal, @mmarionncern, @imarches, @makortel, @acaudron, @jdolen, @ferencek, @rociovilar, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @swertz, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@arizzi arizzi mentioned this pull request Nov 21, 2017
Closed
@slava77
Copy link
Contributor

slava77 commented Nov 21, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24588/console Started: 2017/11/21 18:36

@cmsbuild
Copy link
Contributor

+1
Tested at: a613ede
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21399/24588/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a613ede
daaa3b5
e75577e
84e9ce9
11b1e48
0b663a3
f20ff96
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21399/24588/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21399/24588/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21399/24588/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2779661
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779382
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

perrotta
perrotta reviewed Nov 22, 2017
View reviewed changes
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc
@@ -276,6 +277,25 @@ class GenWeightsTableProducer : public edm::global::EDProducer<edm::StreamCache<
break;
}
}
} else if (groups.str(2) == "NNPDF30_lo_as_0130.LHgrid") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticing that the corresponding updates in the master have comments added, see
https://github.com/cms-sw/cmssw/pull/21300/files#diff-5e612deb23d740e47f5b7ede04e2b5bbR280
(not an issue, anyhow)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that it is ok in the master and is just a set of comments I'd leave it as it is (if I cherry pick the master commit on 94Xbranch I'd change the order of commits and I'd like to avoid any more troubles with mergeability and rebases)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

backport of #21376 and #21300

@perrotta perrotta mentioned this pull request Nov 27, 2017
Closed
@davidlange6
Copy link
Contributor

hi all Please raise any issues with this PR by the release planning meeting tomorrow

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f3a1d4d into cms-sw:CMSSW_9_4_X Nov 28, 2017
@gpetruc gpetruc deleted the 94XmasterForNov21stPR branch November 30, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
analysis-pending comparison-available dqm-pending orp-approved pdmv-pending pending-signatures reconstruction-approved tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet